Commit 94946f9e authored by Lecopzer Chen's avatar Lecopzer Chen Committed by Andrew Morton
Browse files

arm64: add hw_nmi_get_sample_period for preparation of lockup detector 

Set safe maximum CPU frequency to 5 GHz in case a particular platform
doesn't implement cpufreq driver.  Although, architecture doesn't put any
restrictions on maximum frequency but 5 GHz seems to be safe maximum given
the available Arm CPUs in the market which are clocked much less than 5
GHz.

On the other hand, we can't make it much higher as it would lead to a
large hard-lockup detection timeout on parts which are running slower (eg.
1GHz on Developerbox) and doesn't possess a cpufreq driver.

Link: https://lkml.kernel.org/r/20230519101840.v5.17.Ia9d02578e89c3f44d3cb12eec8b0176603c8ab2f@changeid


Co-developed-by: default avatarSumit Garg <sumit.garg@linaro.org>
Signed-off-by: default avatarSumit Garg <sumit.garg@linaro.org>
Co-developed-by: default avatarPingfan Liu <kernelfans@gmail.com>
Signed-off-by: default avatarPingfan Liu <kernelfans@gmail.com>
Signed-off-by: default avatarLecopzer Chen <lecopzer.chen@mediatek.com>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Colin Cross <ccross@android.com>
Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Ian Rogers <irogers@google.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Masayoshi Mizuma <msys.mizuma@gmail.com>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: "Ravi V. Shankar" <ravi.v.shankar@intel.com>
Cc: Ricardo Neri <ricardo.neri@intel.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: Tzung-Bi Shih <tzungbi@chromium.org>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 930d8f8d

arch/arm64/kernel/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -45,6 +45,7 @@ obj-$(CONFIG_FUNCTION_TRACER) += ftrace.o entry-ftrace.o 
obj-$(CONFIG_MODULES)			+= module.o

obj-$(CONFIG_ARM64_MODULE_PLTS)		+= module-plts.o

obj-$(CONFIG_PERF_EVENTS)		+= perf_regs.o perf_callchain.o

obj-$(CONFIG_HARDLOCKUP_DETECTOR_PERF)	+= watchdog_hld.o

obj-$(CONFIG_HAVE_HW_BREAKPOINT)	+= hw_breakpoint.o

obj-$(CONFIG_CPU_PM)			+= sleep.o suspend.o

obj-$(CONFIG_CPU_IDLE)			+= cpuidle.o

arch/arm64/kernel/watchdog_hld.c

0 → 100644
+24 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

#include <linux/cpufreq.h>



/*

 * Safe maximum CPU frequency in case a particular platform doesn't implement

 * cpufreq driver. Although, architecture doesn't put any restrictions on

 * maximum frequency but 5 GHz seems to be safe maximum given the available

 * Arm CPUs in the market which are clocked much less than 5 GHz. On the other

 * hand, we can't make it much higher as it would lead to a large hard-lockup

 * detection timeout on parts which are running slower (eg. 1GHz on

 * Developerbox) and doesn't possess a cpufreq driver.

 */

#define SAFE_MAX_CPU_FREQ	5000000000UL // 5 GHz

u64 hw_nmi_get_sample_period(int watchdog_thresh)

{

	unsigned int cpu = smp_processor_id();

	unsigned long max_cpu_freq;



	max_cpu_freq = cpufreq_get_hw_max_freq(cpu) * 1000UL;

	if (!max_cpu_freq)

		max_cpu_freq = SAFE_MAX_CPU_FREQ;



	return (u64)max_cpu_freq * watchdog_thresh;

}