Commit 9474be34 authored by Carlos Llamas's avatar Carlos Llamas Committed by Greg Kroah-Hartman
Browse files

binder: add failed transaction logging info 



Make sure we log relevant information about failed transactions such as
the target proc/thread, call type and transaction id. These details are
particularly important when debugging userspace issues.

Acked-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
Acked-by: default avatarTodd Kjos <tkjos@google.com>
Signed-off-by: default avatarCarlos Llamas <cmllamas@google.com>
Link: https://lore.kernel.org/r/20220429235644.697372-2-cmllamas@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 83b716d1

drivers/android/binder.c

+6 −2
Original line number Diff line number Diff line
@@ -3470,8 +3470,12 @@ static void binder_transaction(struct binder_proc *proc, 
	}



	binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,

		     "%d:%d transaction failed %d/%d, size %lld-%lld line %d\n",

		     proc->pid, thread->pid, return_error, return_error_param,

		     "%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n",

		     proc->pid, thread->pid, reply ? "reply" :

		     (tr->flags & TF_ONE_WAY ? "async" : "call"),

		     target_proc ? target_proc->pid : 0,

		     target_thread ? target_thread->pid : 0,

		     t_debug_id, return_error, return_error_param,

		     (u64)tr->data_size, (u64)tr->offsets_size,

		     return_error_line);