Commit 9444794b authored by Cai Huoqing's avatar Cai Huoqing Committed by Jonathan Cameron
Browse files

iio: adc: max1118: Make use of the helper function dev_err_probe() 



When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20211008092858.495-4-caihuoqing@baidu.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 922f694b

drivers/iio/adc/max1118.c

+3 −4
Original line number Diff line number Diff line
@@ -221,10 +221,9 @@ static int max1118_probe(struct spi_device *spi) 


	if (id->driver_data == max1118) {

		adc->reg = devm_regulator_get(&spi->dev, "vref");

		if (IS_ERR(adc->reg)) {

			dev_err(&spi->dev, "failed to get vref regulator\n");

			return PTR_ERR(adc->reg);

		}

		if (IS_ERR(adc->reg))

			return dev_err_probe(&spi->dev, PTR_ERR(adc->reg),

					     "failed to get vref regulator\n");

		ret = regulator_enable(adc->reg);

		if (ret)

			return ret;