Commit 943f4e64 authored by Vitaly Rodionov's avatar Vitaly Rodionov Committed by Takashi Iwai
Browse files

ALSA: hda: cs35l41: Correct error condition handling 



Function cs_dsp_coeff_write_ctrl() can return 3 possible values:
0 - no change, 1 - value has changed and -1 - error, so positive value
is not an error.
Fixes: 7406bdbc ("ASoC: wm_adsp: Return whether changed when writing controls")

Signed-off-by: default avatarVitaly Rodionov <vitalyr@opensource.cirrus.com>
Signed-off-by: default avatarStefan Binding <sbinding@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230213145008.1215849-2-sbinding@opensource.cirrus.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent aacdac35

sound/pci/hda/hda_cs_dsp_ctl.c

+2 −2
Original line number Diff line number Diff line
@@ -218,10 +218,10 @@ int hda_cs_dsp_write_ctl(struct cs_dsp *dsp, const char *name, int type, 
	cs_ctl = cs_dsp_get_ctl(dsp, name, type, alg);

	ret = cs_dsp_coeff_write_ctrl(cs_ctl, 0, buf, len);

	mutex_unlock(&dsp->pwr_lock);

	if (ret)

	if (ret < 0)

		return ret;



	if (cs_ctl->flags & WMFW_CTL_FLAG_SYS)

	if (ret == 0 || (cs_ctl->flags & WMFW_CTL_FLAG_SYS))

		return 0;



	ctl = cs_ctl->priv;