Commit 941c998b authored by Luiz Augusto von Dentz's avatar Luiz Augusto von Dentz
Browse files

Bluetooth: hci_sync: Fix handling of HCI_QUIRK_STRICT_DUPLICATE_FILTER 

When HCI_QUIRK_STRICT_DUPLICATE_FILTER is set LE scanning requires
periodic restarts of the scanning procedure as the controller would
consider device previously found as duplicated despite of RSSI changes,
but in order to set the scan timeout properly set le_scan_restart needs
to be synchronous so it shall not use hci_cmd_sync_queue which defers
the command processing to cmd_sync_work.

Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/linux-bluetooth/578e6d7afd676129decafba846a933f5@agner.ch/#t


Fixes: 27d54b77 ("Bluetooth: Rework le_scan_restart for hci_sync")
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent 187f8b64

net/bluetooth/hci_sync.c

+4 −9
Original line number Diff line number Diff line
@@ -413,11 +413,6 @@ static int hci_le_scan_restart_sync(struct hci_dev *hdev) 
					   LE_SCAN_FILTER_DUP_ENABLE);

}



static int le_scan_restart_sync(struct hci_dev *hdev, void *data)

{

	return hci_le_scan_restart_sync(hdev);

}



static void le_scan_restart(struct work_struct *work)

{

	struct hci_dev *hdev = container_of(work, struct hci_dev,
@@ -427,15 +422,15 @@ static void le_scan_restart(struct work_struct *work) 


	bt_dev_dbg(hdev, "");



	hci_dev_lock(hdev);



	status = hci_cmd_sync_queue(hdev, le_scan_restart_sync, NULL, NULL);

	status = hci_le_scan_restart_sync(hdev);

	if (status) {

		bt_dev_err(hdev, "failed to restart LE scan: status %d",

			   status);

		goto unlock;

		return;

	}



	hci_dev_lock(hdev);



	if (!test_bit(HCI_QUIRK_STRICT_DUPLICATE_FILTER, &hdev->quirks) ||

	    !hdev->discovery.scan_start)

		goto unlock;