Commit 9406415f authored by Peter Zijlstra's avatar Peter Zijlstra
Browse files

sched/debug: Rename the sched_debug parameter to sched_verbose 



CONFIG_SCHED_DEBUG is the build-time Kconfig knob, the boot param
sched_debug and the /debug/sched/debug_enabled knobs control the
sched_debug_enabled variable, but what they really do is make
SCHED_DEBUG more verbose, so rename the lot.

Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
parent 0c2de3f0

Documentation/admin-guide/kernel-parameters.txt

+1 −1
Original line number Diff line number Diff line
@@ -4725,7 +4725,7 @@ 


	sbni=		[NET] Granch SBNI12 leased line adapter



	sched_debug	[KNL] Enables verbose scheduler debug messages.

	sched_verbose	[KNL] Enables verbose scheduler debug messages.



	schedstats=	[KNL,X86] Enable or disable scheduled statistics.

			Allowed values are enable and disable. This feature

Documentation/scheduler/sched-domains.rst

+5 −5
Original line number Diff line number Diff line
@@ -74,8 +74,8 @@ for a given topology level by creating a sched_domain_topology_level array and 
calling set_sched_topology() with this array as the parameter.



The sched-domains debugging infrastructure can be enabled by enabling

CONFIG_SCHED_DEBUG and adding 'sched_debug' to your cmdline. If you forgot to

tweak your cmdline, you can also flip the /sys/kernel/debug/sched_debug

knob. This enables an error checking parse of the sched domains which should

catch most possible errors (described above). It also prints out the domain

structure in a visual format.
 
CONFIG_SCHED_DEBUG and adding 'sched_debug_verbose' to your cmdline. If you

forgot to tweak your cmdline, you can also flip the

/sys/kernel/debug/sched/verbose knob. This enables an error checking parse of

the sched domains which should catch most possible errors (described above). It

also prints out the domain structure in a visual format.

kernel/sched/debug.c

+2 −2
Original line number Diff line number Diff line
@@ -275,7 +275,7 @@ static const struct file_operations sched_dynamic_fops = { 


#endif /* CONFIG_PREEMPT_DYNAMIC */



__read_mostly bool sched_debug_enabled;

__read_mostly bool sched_debug_verbose;



static const struct seq_operations sched_debug_sops;
@@ -300,7 +300,7 @@ static __init int sched_init_debug(void) 
	debugfs_sched = debugfs_create_dir("sched", NULL);



	debugfs_create_file("features", 0644, debugfs_sched, NULL, &sched_feat_fops);

	debugfs_create_bool("debug_enabled", 0644, debugfs_sched, &sched_debug_enabled);

	debugfs_create_bool("verbose", 0644, debugfs_sched, &sched_debug_verbose);

#ifdef CONFIG_PREEMPT_DYNAMIC

	debugfs_create_file("preempt", 0644, debugfs_sched, NULL, &sched_dynamic_fops);

#endif

kernel/sched/sched.h

+1 −1
Original line number Diff line number Diff line
@@ -2363,7 +2363,7 @@ extern struct sched_entity *__pick_first_entity(struct cfs_rq *cfs_rq); 
extern struct sched_entity *__pick_last_entity(struct cfs_rq *cfs_rq);



#ifdef	CONFIG_SCHED_DEBUG

extern bool sched_debug_enabled;

extern bool sched_debug_verbose;



extern void print_cfs_stats(struct seq_file *m, int cpu);

extern void print_rt_stats(struct seq_file *m, int cpu);

kernel/sched/topology.c

+6 −6
Original line number Diff line number Diff line
@@ -14,15 +14,15 @@ static cpumask_var_t sched_domains_tmpmask2; 


static int __init sched_debug_setup(char *str)

{

	sched_debug_enabled = true;

	sched_debug_verbose = true;



	return 0;

}

early_param("sched_debug", sched_debug_setup);

early_param("sched_verbose", sched_debug_setup);



static inline bool sched_debug(void)

{

	return sched_debug_enabled;

	return sched_debug_verbose;

}



#define SD_FLAG(_name, mflags) [__##_name] = { .meta_flags = mflags, .name = #_name },
@@ -131,7 +131,7 @@ static void sched_domain_debug(struct sched_domain *sd, int cpu) 
{

	int level = 0;



	if (!sched_debug_enabled)

	if (!sched_debug_verbose)

		return;



	if (!sd) {
@@ -152,7 +152,7 @@ static void sched_domain_debug(struct sched_domain *sd, int cpu) 
}

#else /* !CONFIG_SCHED_DEBUG */



# define sched_debug_enabled 0

# define sched_debug_verbose 0

# define sched_domain_debug(sd, cpu) do { } while (0)

static inline bool sched_debug(void)

{
@@ -2141,7 +2141,7 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att 
	if (has_asym)

		static_branch_inc_cpuslocked(&sched_asym_cpucapacity);



	if (rq && sched_debug_enabled) {

	if (rq && sched_debug_verbose) {

		pr_info("root domain span: %*pbl (max cpu_capacity = %lu)\n",

			cpumask_pr_args(cpu_map), rq->rd->max_cpu_capacity);

	}