Commit 93c747ed authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

usb: Fix fall-through warnings for Clang 

In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break/return/fallthrough
statements instead of letting the code fall through to the next
case.

Link: https://github.com/KSPP/linux/issues/115


Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/a76da7ca5b4f41c13d27b298accb8222d0b04e61.1605896060.git.gustavoars@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 52a0372a

drivers/usb/gadget/function/f_fs.c

+2 −0
Original line number Diff line number Diff line
@@ -678,6 +678,8 @@ static __poll_t ffs_ep0_poll(struct file *file, poll_table *wait) 
			mask |= (EPOLLIN | EPOLLOUT);

			break;

		}

		break;



	case FFS_CLOSING:

		break;

	case FFS_DEACTIVATED:

drivers/usb/gadget/function/f_loopback.c

+1 −1
Original line number Diff line number Diff line
@@ -274,7 +274,7 @@ static void loopback_complete(struct usb_ep *ep, struct usb_request *req) 
	default:

		ERROR(cdev, "%s loop complete --> %d, %d/%d\n", ep->name,

				status, req->actual, req->length);

		/* FALLTHROUGH */

		fallthrough;



	/* NOTE:  since this driver doesn't maintain an explicit record

	 * of requests it submitted (just maintains qlen count), we

drivers/usb/gadget/function/f_sourcesink.c

+1 −0
Original line number Diff line number Diff line
@@ -559,6 +559,7 @@ static void source_sink_complete(struct usb_ep *ep, struct usb_request *req) 
#if 1

		DBG(cdev, "%s complete --> %d, %d/%d\n", ep->name,

				status, req->actual, req->length);

		break;

#endif

	case -EREMOTEIO:		/* short read */

		break;

drivers/usb/gadget/udc/dummy_hcd.c

+2 −0
Original line number Diff line number Diff line
@@ -553,6 +553,7 @@ static int dummy_enable(struct usb_ep *_ep, 
				/* we'll fake any legal size */

				break;

			/* save a return statement */

			fallthrough;

		default:

			goto done;

		}
@@ -595,6 +596,7 @@ static int dummy_enable(struct usb_ep *_ep, 
			if (max <= 1023)

				break;

			/* save a return statement */

			fallthrough;

		default:

			goto done;

		}

drivers/usb/host/fotg210-hcd.c

+1 −1
Original line number Diff line number Diff line
@@ -5276,7 +5276,7 @@ static int fotg210_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, 
		 */

		if (urb->transfer_buffer_length > (16 * 1024))

			return -EMSGSIZE;

		/* FALLTHROUGH */

		fallthrough;

	/* case PIPE_BULK: */

	default:

		if (!qh_urb_transaction(fotg210, urb, &qtd_list, mem_flags))