Commit 93c2cdc9 authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Borislav Petkov
Browse files

x86/fpu/xstate: Clear xstate header in copy_xstate_to_uabi_buf() again 



The change which made copy_xstate_to_uabi_buf() usable for
[x]fpregs_get() removed the zeroing of the header which means the
header, which is copied to user space later, contains except for the
xfeatures member, random stack content.

Add the memset() back to zero it before usage.

Fixes: eb6f5172 ("x86/fpu: Make copy_xstate_to_kernel() usable for [x]fpregs_get()")
Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/875yy3wb8h.ffs@nanos.tec.linutronix.de
parent 6f9866a1

arch/x86/kernel/fpu/xstate.c

+1 −0
Original line number Diff line number Diff line
@@ -982,6 +982,7 @@ void copy_xstate_to_uabi_buf(struct membuf to, struct task_struct *tsk, 
	unsigned int zerofrom;

	int i;



	memset(&header, 0, sizeof(header));

	header.xfeatures = xsave->header.xfeatures;



	/* Mask out the feature bits depending on copy mode */