Commit 939d002b authored by Doug Brown's avatar Doug Brown Committed by Thierry Reding
Browse files

pwm: pxa: Remove clk enable/disable from pxa_pwm_config 



Now that pxa_pwm_apply always enables the clock first, there is no need
for pxa_pwm_config to do any clock enabling/disabling.

Signed-off-by: default avatarDoug Brown <doug@schmorgal.com>
Reviewed-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20221113233639.24244-4-doug@schmorgal.com


Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 152f2d1d

drivers/pwm/pwm-pxa.c

+0 −9
Original line number Diff line number Diff line
@@ -64,7 +64,6 @@ static int pxa_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, 
	unsigned long long c;

	unsigned long period_cycles, prescale, pv, dc;

	unsigned long offset;

	int rc;



	offset = pwm->hwpwm ? 0x10 : 0;
@@ -86,18 +85,10 @@ static int pxa_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, 
	else

		dc = mul_u64_u64_div_u64(pv + 1, duty_ns, period_ns);



	/* NOTE: the clock to PWM has to be enabled first

	 * before writing to the registers

	 */

	rc = clk_prepare_enable(pc->clk);

	if (rc < 0)

		return rc;



	writel(prescale, pc->mmio_base + offset + PWMCR);

	writel(dc, pc->mmio_base + offset + PWMDCR);

	writel(pv, pc->mmio_base + offset + PWMPCR);



	clk_disable_unprepare(pc->clk);

	return 0;

}