Unverified Commit 939bc545 authored by Dan Carpenter's avatar Dan Carpenter Committed by Xu Yilun
Browse files

fpga: prevent integer overflow in dfl_feature_ioctl_set_irq() 



The "hdr.count * sizeof(s32)" multiplication can overflow on 32 bit
systems leading to memory corruption.  Use array_size() to fix that.

Fixes: 322b598b ("fpga: dfl: introduce interrupt trigger setting API")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarXu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/YxBAtYCM38dM7yzI@kili


Signed-off-by: default avatarXu Yilun <yilun.xu@intel.com>
parent e167b2c3

drivers/fpga/dfl.c

+1 −1
Original line number Diff line number Diff line
@@ -1866,7 +1866,7 @@ long dfl_feature_ioctl_set_irq(struct platform_device *pdev, 
		return -EINVAL;



	fds = memdup_user((void __user *)(arg + sizeof(hdr)),

			  hdr.count * sizeof(s32));

			  array_size(hdr.count, sizeof(s32)));

	if (IS_ERR(fds))

		return PTR_ERR(fds);