Commit 9393eb50 authored by Yufeng Mo's avatar Yufeng Mo Committed by David S. Miller
Browse files

net: hns3: clean up unnecessary parentheses in macro definitions 



In macro definitions, parentheses are unnecessary in some cases,
such as the calling parameter of a function, the left variable
of the equal sign, and so on. So remove these unnecessary
parentheses according to these rules.

Signed-off-by: default avatarYufeng Mo <moyufeng@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9d2a1cea

drivers/net/ethernet/hisilicon/hns3/hnae3.h

+3 −3
Original line number Diff line number Diff line
@@ -272,7 +272,7 @@ struct hnae3_ring_chain_node { 
};



#define HNAE3_IS_TX_RING(node) \

	(((node)->flag & (1 << HNAE3_RING_TYPE_B)) == HNAE3_RING_TYPE_TX)

	(((node)->flag & 1 << HNAE3_RING_TYPE_B) == HNAE3_RING_TYPE_TX)



/* device specification info from firmware */

struct hnae3_dev_specs {
@@ -775,9 +775,9 @@ struct hnae3_handle { 
#define hnae3_get_field(origin, mask, shift) (((origin) & (mask)) >> (shift))



#define hnae3_set_bit(origin, shift, val) \

	hnae3_set_field((origin), (0x1 << (shift)), (shift), (val))

	hnae3_set_field(origin, 0x1 << (shift), shift, val)

#define hnae3_get_bit(origin, shift) \

	hnae3_get_field((origin), (0x1 << (shift)), (shift))

	hnae3_get_field(origin, 0x1 << (shift), shift)



#define HNAE3_DBG_TM_NODES		"tm_nodes"

#define HNAE3_DBG_TM_PRI		"tm_priority"

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ 
#define CREATE_TRACE_POINTS

#include "hns3_trace.h"



#define hns3_set_field(origin, shift, val)	((origin) |= ((val) << (shift)))

#define hns3_set_field(origin, shift, val)	((origin) |= (val) << (shift))

#define hns3_tx_bd_count(S)	DIV_ROUND_UP(S, HNS3_MAX_BD_SIZE)



#define hns3_rl_err(fmt, ...)						\

drivers/net/ethernet/hisilicon/hns3/hns3_enet.h

+5 −5
Original line number Diff line number Diff line
@@ -554,7 +554,7 @@ static inline void hns3_write_reg(void __iomem *base, u32 reg, u32 value) 
}



#define hns3_read_dev(a, reg) \

	hns3_read_reg((a)->io_base, (reg))

	hns3_read_reg((a)->io_base, reg)



static inline bool hns3_nic_resetting(struct net_device *netdev)

{
@@ -564,7 +564,7 @@ static inline bool hns3_nic_resetting(struct net_device *netdev) 
}



#define hns3_write_dev(a, reg, value) \

	hns3_write_reg((a)->io_base, (reg), (value))

	hns3_write_reg((a)->io_base, reg, value)



#define ring_to_dev(ring) ((ring)->dev)
@@ -588,15 +588,15 @@ static inline unsigned int hns3_page_order(struct hns3_enet_ring *ring) 


/* iterator for handling rings in ring group */

#define hns3_for_each_ring(pos, head) \

	for (pos = (head).ring; pos; pos = pos->next)

	for (pos = (head).ring; (pos); pos = (pos)->next)



#define hns3_get_handle(ndev) \

	(((struct hns3_nic_priv *)netdev_priv(ndev))->ae_handle)



#define hns3_gl_usec_to_reg(int_gl) (int_gl >> 1)

#define hns3_gl_usec_to_reg(int_gl) ((int_gl) >> 1)

#define hns3_gl_round_down(int_gl) round_down(int_gl, 2)



#define hns3_rl_usec_to_reg(int_rl) (int_rl >> 2)

#define hns3_rl_usec_to_reg(int_rl) ((int_rl) >> 2)

#define hns3_rl_round_down(int_rl) round_down(int_rl, 4)



void hns3_ethtool_set_ops(struct net_device *netdev);

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h

+2 −2
Original line number Diff line number Diff line
@@ -1144,9 +1144,9 @@ static inline void hclge_write_reg(void __iomem *base, u32 reg, u32 value) 
}



#define hclge_write_dev(a, reg, value) \

	hclge_write_reg((a)->io_base, (reg), (value))

	hclge_write_reg((a)->io_base, reg, value)

#define hclge_read_dev(a, reg) \

	hclge_read_reg((a)->io_base, (reg))

	hclge_read_reg((a)->io_base, reg)



static inline u32 hclge_read_reg(u8 __iomem *base, u32 reg)

{

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+1 −1
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ 
#include "hnae3.h"



#define HCLGE_NAME			"hclge"

#define HCLGE_STATS_READ(p, offset) (*((u64 *)((u8 *)(p) + (offset))))

#define HCLGE_STATS_READ(p, offset) (*(u64 *)((u8 *)(p) + (offset)))

#define HCLGE_MAC_STATS_FIELD_OFF(f) (offsetof(struct hclge_mac_stats, f))



#define HCLGE_BUF_SIZE_UNIT	256U