Commit 9387cf59 authored by Reinette Chatre's avatar Reinette Chatre Committed by Alex Williamson
Browse files

vfio/pci: Update stale comment 



In preparation for surrounding code change it is helpful to
ensure that existing comments are accurate.

Remove inaccurate comment about direct access and update
the rest of the comment to reflect the purpose of writing
the cached MSI message to the device.

Suggested-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Link: https://lore.kernel.org/lkml/20230330164050.0069e2a5.alex.williamson@redhat.com/


Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/5b605ce7dcdab5a5dfef19cec4d73ae2fdad3ae1.1683740667.git.reinette.chatre@intel.com


Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent 63972f63

drivers/vfio/pci/vfio_pci_intrs.c

+3 −5
Original line number Diff line number Diff line
@@ -428,11 +428,9 @@ static int vfio_msi_set_vector_signal(struct vfio_pci_core_device *vdev, 
	}



	/*

	 * The MSIx vector table resides in device memory which may be cleared

	 * via backdoor resets. We don't allow direct access to the vector

	 * table so even if a userspace driver attempts to save/restore around

	 * such a reset it would be unsuccessful. To avoid this, restore the

	 * cached value of the message prior to enabling.

	 * If the vector was previously allocated, refresh the on-device

	 * message data before enabling in case it had been cleared or

	 * corrupted (e.g. due to backdoor resets) since writing.

	 */

	cmd = vfio_pci_memory_lock_and_enable(vdev);

	if (msix) {