Unverified Commit 93618e5e authored by Zhang Qilong's avatar Zhang Qilong Committed by Mark Brown
Browse files

ASoC: stm: Fix PM disable depth imbalance in stm32_i2s_probe 



The pm_runtime_enable will increase power disable depth. Thus
a pairing decrement is needed on the error handling path to
keep it balanced according to context. We fix it by moving
pm_runtime_enable to the endding of stm32_i2s_probe.

Fixes:32a956a1 ("ASoC: stm32: i2s: add pm_runtime support")

Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Reviewed-by: default avatarOlivier Moysan <olivier.moysan@foss.st.com>
Link: https://lore.kernel.org/r/20220927142640.64647-1-zhangqilong3@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 45560891

sound/soc/stm/stm32_i2s.c

+2 −2
Original line number Diff line number Diff line
@@ -1136,8 +1136,6 @@ static int stm32_i2s_probe(struct platform_device *pdev) 
		return dev_err_probe(&pdev->dev, PTR_ERR(i2s->regmap),

				     "Regmap init error\n");



	pm_runtime_enable(&pdev->dev);



	ret = snd_dmaengine_pcm_register(&pdev->dev, &stm32_i2s_pcm_config, 0);

	if (ret)

		return dev_err_probe(&pdev->dev, ret, "PCM DMA register error\n");
@@ -1180,6 +1178,8 @@ static int stm32_i2s_probe(struct platform_device *pdev) 
			FIELD_GET(I2S_VERR_MIN_MASK, val));

	}



	pm_runtime_enable(&pdev->dev);



	return ret;



error: