Commit 93419139 authored by Tong Tiangen's avatar Tong Tiangen Committed by Andrew Morton
Browse files

memory tier: release the new_memtier in find_create_memory_tier() 

In find_create_memory_tier(), if failed to register device, then we should
release new_memtier from the tier list and put device instead of memtier.

Link: https://lkml.kernel.org/r/20230129040651.1329208-1-tongtiangen@huawei.com


Fixes: 9832fb87 ("mm/demotion: expose memory tier details via sysfs")
Signed-off-by: default avatarTong Tiangen <tongtiangen@huawei.com>
Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Cc: Hanjun Guo <guohanjun@huawei.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Guohanjun <guohanjun@huawei.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 8f17febb

mm/memory-tiers.c

+2 −2
Original line number Diff line number Diff line
@@ -211,8 +211,8 @@ static struct memory_tier *find_create_memory_tier(struct memory_dev_type *memty 


	ret = device_register(&new_memtier->dev);

	if (ret) {

		list_del(&memtier->list);

		put_device(&memtier->dev);

		list_del(&new_memtier->list);

		put_device(&new_memtier->dev);

		return ERR_PTR(ret);

	}

	memtier = new_memtier;