Commit 931c38e1 authored by Kemeng Shi's avatar Kemeng Shi Committed by Andrew Morton
Browse files

mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear 

Remove unused addr in __page_table_check_pud_clear and
page_table_check_pud_clear.

Link: https://lkml.kernel.org/r/20230713172636.1705415-6-shikemeng@huaweicloud.com


Signed-off-by: default avatarKemeng Shi <shikemeng@huaweicloud.com>
Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 1831414c

arch/x86/include/asm/pgtable.h

+1 −1
Original line number Diff line number Diff line
@@ -1144,7 +1144,7 @@ static inline pud_t pudp_huge_get_and_clear(struct mm_struct *mm, 
{

	pud_t pud = native_pudp_get_and_clear(pudp);



	page_table_check_pud_clear(mm, addr, pud);

	page_table_check_pud_clear(mm, pud);



	return pud;

}

include/linux/page_table_check.h

+4 −7
Original line number Diff line number Diff line
@@ -16,8 +16,7 @@ extern struct page_ext_operations page_table_check_ops; 
void __page_table_check_zero(struct page *page, unsigned int order);

void __page_table_check_pte_clear(struct mm_struct *mm, pte_t pte);

void __page_table_check_pmd_clear(struct mm_struct *mm, pmd_t pmd);

void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,

				  pud_t pud);

void __page_table_check_pud_clear(struct mm_struct *mm, pud_t pud);

void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr,

				pte_t *ptep, pte_t pte);

void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr,
@@ -60,13 +59,12 @@ static inline void page_table_check_pmd_clear(struct mm_struct *mm, pmd_t pmd) 
	__page_table_check_pmd_clear(mm, pmd);

}



static inline void page_table_check_pud_clear(struct mm_struct *mm,

					      unsigned long addr, pud_t pud)

static inline void page_table_check_pud_clear(struct mm_struct *mm, pud_t pud)

{

	if (static_branch_likely(&page_table_check_disabled))

		return;



	__page_table_check_pud_clear(mm, addr, pud);

	__page_table_check_pud_clear(mm, pud);

}



static inline void page_table_check_pte_set(struct mm_struct *mm,
@@ -127,8 +125,7 @@ static inline void page_table_check_pmd_clear(struct mm_struct *mm, pmd_t pmd) 
{

}



static inline void page_table_check_pud_clear(struct mm_struct *mm,

					      unsigned long addr, pud_t pud)

static inline void page_table_check_pud_clear(struct mm_struct *mm, pud_t pud)

{

}

include/linux/pgtable.h

+1 −1
Original line number Diff line number Diff line
@@ -438,7 +438,7 @@ static inline pud_t pudp_huge_get_and_clear(struct mm_struct *mm, 
	pud_t pud = *pudp;



	pud_clear(pudp);

	page_table_check_pud_clear(mm, address, pud);

	page_table_check_pud_clear(mm, pud);



	return pud;

}

mm/page_table_check.c

+2 −3
Original line number Diff line number Diff line
@@ -171,8 +171,7 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, pmd_t pmd) 
}

EXPORT_SYMBOL(__page_table_check_pmd_clear);



void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,

				  pud_t pud)

void __page_table_check_pud_clear(struct mm_struct *mm, pud_t pud)

{

	if (&init_mm == mm)

		return;
@@ -217,7 +216,7 @@ void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr, 
	if (&init_mm == mm)

		return;



	__page_table_check_pud_clear(mm, addr, *pudp);

	__page_table_check_pud_clear(mm, *pudp);

	if (pud_user_accessible_page(pud)) {

		page_table_check_set(pud_pfn(pud), PUD_SIZE >> PAGE_SHIFT,

				     pud_write(pud));