Commit 931262e6 authored by Peter Geis's avatar Peter Geis Committed by Lorenzo Pieralisi
Browse files

dt-bindings: PCI: Remove fallback from Rockchip DesignWare binding 

The snps,dw-pcie binds to a standalone driver. It is not fully
compatible with the Rockchip implementation and causes a hang if it
binds to the device.

Remove this binding as a valid fallback.

Link: https://lore.kernel.org/r/20220429123832.2376381-2-pgwipeout@gmail.com


Signed-off-by: default avatarPeter Geis <pgwipeout@gmail.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
parent bc49681c

Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml

+1 −11
Original line number Diff line number Diff line
@@ -19,20 +19,10 @@ description: |+ 
allOf:

  - $ref: /schemas/pci/pci-bus.yaml#



# We need a select here so we don't match all nodes with 'snps,dw-pcie'

select:

  properties:

    compatible:

      contains:

        const: rockchip,rk3568-pcie

  required:

    - compatible



properties:

  compatible:

    items:

      - const: rockchip,rk3568-pcie

      - const: snps,dw-pcie



  reg:

    items:
@@ -110,7 +100,7 @@ examples: 
        #size-cells = <2>;



        pcie3x2: pcie@fe280000 {

            compatible = "rockchip,rk3568-pcie", "snps,dw-pcie";

            compatible = "rockchip,rk3568-pcie";

            reg = <0x3 0xc0800000 0x0 0x390000>,

                  <0x0 0xfe280000 0x0 0x10000>,

                  <0x3 0x80000000 0x0 0x100000>;