Commit 93103f6e authored by Jianqun Xu's avatar Jianqun Xu Committed by Linus Walleij
Browse files

gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type 



There has spin lock for irq set type already, so drop irq_gc_lock and
irq_gc_unlock.

Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarJianqun Xu <jay.xu@rock-chips.com>
Link: https://lore.kernel.org/r/20210816012135.1119234-1-jay.xu@rock-chips.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 3bcbd1a8

drivers/gpio/gpio-rockchip.c

+0 −2
Original line number Diff line number Diff line
@@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) 
		irq_set_handler_locked(d, handle_level_irq);



	raw_spin_lock_irqsave(&bank->slock, flags);

	irq_gc_lock(gc);



	level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type);

	polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity);
@@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) 
	rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type);

	rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity);

out:

	irq_gc_unlock(gc);

	raw_spin_unlock_irqrestore(&bank->slock, flags);



	return ret;