Commit 92fbb6d1 authored by Wei Chen's avatar Wei Chen Committed by Wolfram Sang
Browse files

i2c: xgene-slimpro: Fix out-of-bounds bug in xgene_slimpro_i2c_xfer() 



The data->block[0] variable comes from user and is a number between
0-255. Without proper check, the variable may be very large to cause
an out-of-bounds when performing memcpy in slimpro_i2c_blkwr.

Fix this bug by checking the value of writelen.

Fixes: f6505fba ("i2c: add SLIMpro I2C device driver on APM X-Gene platform")
Signed-off-by: default avatarWei Chen <harperchen1110@gmail.com>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent d9826351

drivers/i2c/busses/i2c-xgene-slimpro.c

+3 −0
Original line number Diff line number Diff line
@@ -308,6 +308,9 @@ static int slimpro_i2c_blkwr(struct slimpro_i2c_dev *ctx, u32 chip, 
	u32 msg[3];

	int rc;



	if (writelen > I2C_SMBUS_BLOCK_MAX)

		return -EINVAL;



	memcpy(ctx->dma_buffer, data, writelen);

	paddr = dma_map_single(ctx->dev, ctx->dma_buffer, writelen,

			       DMA_TO_DEVICE);