Commit 92f24c6f authored by Wolfram Sang's avatar Wolfram Sang Committed by Jakub Kicinski
Browse files

net_sched: move from strlcpy with unused retval to strscpy 

Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/


Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20220818210228.8635-1-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 19d1c046

net/sched/sch_api.c

+1 −1
Original line number Diff line number Diff line
@@ -195,7 +195,7 @@ EXPORT_SYMBOL(unregister_qdisc); 
void qdisc_get_default(char *name, size_t len)

{

	read_lock(&qdisc_mod_lock);

	strlcpy(name, default_qdisc_ops->id, len);

	strscpy(name, default_qdisc_ops->id, len);

	read_unlock(&qdisc_mod_lock);

}

net/sched/sch_teql.c

+1 −1
Original line number Diff line number Diff line
@@ -492,7 +492,7 @@ static int __init teql_init(void) 


		master = netdev_priv(dev);



		strlcpy(master->qops.id, dev->name, IFNAMSIZ);

		strscpy(master->qops.id, dev->name, IFNAMSIZ);

		err = register_qdisc(&master->qops);



		if (err) {