Commit 92e8d032 authored by Xianting Tian's avatar Xianting Tian Committed by Martin K. Petersen
Browse files

scsi: virtio_scsi: Remove unnecessary condition check 

kmem_cache_destroy() and mempool_destroy() both correctly handle null
pointer parameters. There is no need to check if the parameter is null
before calling these functions.

Link: https://lore.kernel.org/r/1594307167-8807-1-git-send-email-xianting_tian@126.com


Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarXianting Tian <xianting_tian@126.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent b92a4a9f

drivers/scsi/virtio_scsi.c

+4 −8
Original line number Diff line number Diff line
@@ -1002,14 +1002,10 @@ static int __init init(void) 
	return 0;



error:

	if (virtscsi_cmd_pool) {

	mempool_destroy(virtscsi_cmd_pool);

	virtscsi_cmd_pool = NULL;

	}

	if (virtscsi_cmd_cache) {

	kmem_cache_destroy(virtscsi_cmd_cache);

	virtscsi_cmd_cache = NULL;

	}

	return ret;

}