Commit 92cbf865 authored by Dmitry Antipov's avatar Dmitry Antipov Committed by Mauro Carvalho Chehab
Browse files

media: pulse8-cec: handle possible ping error 



Handle (and warn about) possible error waiting for MSGCODE_PING result.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarDmitry Antipov <dmantipov@yandex.ru>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 20de9fda

drivers/media/cec/usb/pulse8/pulse8-cec.c

+5 −2
Original line number Diff line number Diff line
@@ -809,8 +809,11 @@ static void pulse8_ping_eeprom_work_handler(struct work_struct *work) 


	mutex_lock(&pulse8->lock);

	cmd = MSGCODE_PING;

	pulse8_send_and_wait(pulse8, &cmd, 1,

			     MSGCODE_COMMAND_ACCEPTED, 0);

	if (pulse8_send_and_wait(pulse8, &cmd, 1,

				 MSGCODE_COMMAND_ACCEPTED, 0)) {

		dev_warn(pulse8->dev, "failed to ping EEPROM\n");

		goto unlock;

	}



	if (pulse8->vers < 2)

		goto unlock;