Unverified Commit 92c17d16 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/vc4: hvs: Ignore atomic_flush if we're disabled 



atomic_flush will be called for each CRTC even if they aren't enabled.

The whole code we have there will thus run without a properly affected
channel, which can then result in all sorts of weird behaviour.

Reviewed-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
Link: https://lore.kernel.org/r/20221207-rpi-hvs-crtc-misc-v1-8-1f8e0770798b@cerno.tech


Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
parent f92534ea

drivers/gpu/drm/vc4/vc4_hvs.c

+3 −0
Original line number Diff line number Diff line
@@ -579,6 +579,9 @@ void vc4_hvs_atomic_flush(struct drm_crtc *crtc, 
		return;

	}



	if (vc4_state->assigned_channel == VC4_HVS_CHANNEL_DISABLED)

		return;



	if (debug_dump_regs) {

		DRM_INFO("CRTC %d HVS before:\n", drm_crtc_index(crtc));

		vc4_hvs_dump_state(hvs);