Commit 92a9c57c authored by Rick Wertenbroek's avatar Rick Wertenbroek Committed by Lorenzo Pieralisi
Browse files

PCI: rockchip: Remove writes to unused registers 

Remove write accesses to registers that are marked "unused" (and
therefore read-only) in the technical reference manual (TRM)
(see RK3399 TRM 17.6.8.1)

Link: https://lore.kernel.org/r/20230418074700.1083505-2-rick.wertenbroek@gmail.com


Tested-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Signed-off-by: default avatarRick Wertenbroek <rick.wertenbroek@gmail.com>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent ac9a7868

drivers/pci/controller/pcie-rockchip-ep.c

+0 −10
Original line number Diff line number Diff line
@@ -61,10 +61,6 @@ static void rockchip_pcie_clear_ep_ob_atu(struct rockchip_pcie *rockchip, 
			    ROCKCHIP_PCIE_AT_OB_REGION_DESC0(region));

	rockchip_pcie_write(rockchip, 0,

			    ROCKCHIP_PCIE_AT_OB_REGION_DESC1(region));

	rockchip_pcie_write(rockchip, 0,

			    ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR0(region));

	rockchip_pcie_write(rockchip, 0,

			    ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR1(region));

}



static void rockchip_pcie_prog_ep_ob_atu(struct rockchip_pcie *rockchip, u8 fn,
@@ -114,12 +110,6 @@ static void rockchip_pcie_prog_ep_ob_atu(struct rockchip_pcie *rockchip, u8 fn, 
		     PCIE_CORE_OB_REGION_ADDR0_LO_ADDR);

		addr1 = upper_32_bits(cpu_addr);

	}



	/* CPU bus address region */

	rockchip_pcie_write(rockchip, addr0,

			    ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR0(r));

	rockchip_pcie_write(rockchip, addr1,

			    ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR1(r));

}



static int rockchip_pcie_ep_write_header(struct pci_epc *epc, u8 fn, u8 vfn,