Commit 92a84c78 authored by David S. Miller's avatar David S. Miller
Browse files

Merge branch 'ionic-updates' 



Shannon Nelson says:

====================
ionic updates

This set of patches is a bunch of code cleanup, a little
documentation, longer tx sg lists, more ethtool stats,
and a couple more transceiver types.
====================

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 6b9ea5ff 7c7b58ec

Documentation/networking/device_drivers/pensando/ionic.rst

+230 −1
Original line number Diff line number Diff line
@@ -11,6 +11,9 @@ Contents 
========



- Identifying the Adapter

- Enabling the driver

- Configuring the driver

- Statistics

- Support



Identifying the Adapter
@@ -28,12 +31,238 @@ and configure them for use. There should be log entries in the kernel 
messages such as these::



  $ dmesg | grep ionic

  ionic Pensando Ethernet NIC Driver, ver 0.15.0-k

  ionic 0000:b5:00.0: 126.016 Gb/s available PCIe bandwidth (8.0 GT/s PCIe x16 link)

  ionic 0000:b5:00.0 enp181s0: renamed from eth0

  ionic 0000:b5:00.0 enp181s0: Link up - 100 Gbps

  ionic 0000:b6:00.0: 126.016 Gb/s available PCIe bandwidth (8.0 GT/s PCIe x16 link)

  ionic 0000:b6:00.0 enp182s0: renamed from eth0

  ionic 0000:b6:00.0 enp182s0: Link up - 100 Gbps



Driver and firmware version information can be gathered with either of

ethtool or devlink tools::



  $ ethtool -i enp181s0

  driver: ionic

  version: 5.7.0

  firmware-version: 1.8.0-28

  ...



  $ devlink dev info pci/0000:b5:00.0

  pci/0000:b5:00.0:

    driver ionic

    serial_number FLM18420073

    versions:

        fixed:

          asic.id 0x0

          asic.rev 0x0

        running:

          fw 1.8.0-28



See Documentation/networking/devlink/ionic.rst for more information

on the devlink dev info data.



Enabling the driver

===================



The driver is enabled via the standard kernel configuration system,

using the make command::



  make oldconfig/menuconfig/etc.



The driver is located in the menu structure at:



  -> Device Drivers

    -> Network device support (NETDEVICES [=y])

      -> Ethernet driver support

        -> Pensando devices

          -> Pensando Ethernet IONIC Support



Configuring the Driver

======================



MTU

---



Jumbo frame support is available with a maximim size of 9194 bytes.



Interrupt coalescing

--------------------



Interrupt coalescing can be configured by changing the rx-usecs value with

the "ethtool -C" command.  The rx-usecs range is 0-190.  The tx-usecs value

reflects the rx-usecs value as they are tied together on the same interrupt.



SR-IOV

------



Minimal SR-IOV support is currently offered and can be enabled by setting

the sysfs 'sriov_numvfs' value, if supported by your particular firmware

configuration.



Statistics

==========



Basic hardware stats

--------------------



The commands ``netstat -i``, ``ip -s link show``, and ``ifconfig`` show

a limited set of statistics taken directly from firmware.  For example::



  $ ip -s link show enp181s0

  7: enp181s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000

      link/ether 00:ae:cd:00:07:68 brd ff:ff:ff:ff:ff:ff

      RX: bytes  packets  errors  dropped overrun mcast

      414        5        0       0       0       0

      TX: bytes  packets  errors  dropped carrier collsns

      1384       18       0       0       0       0



ethtool -S

----------



The statistics shown from the ``ethtool -S`` command includes a combination of

driver counters and firmware counters, including port and queue specific values.

The driver values are counters computed by the driver, and the firmware values

are gathered by the firmware from the port hardware and passed through the

driver with no further interpretation.



Driver port specific::



     tx_packets: 12

     tx_bytes: 964

     rx_packets: 5

     rx_bytes: 414

     tx_tso: 0

     tx_tso_bytes: 0

     tx_csum_none: 12

     tx_csum: 0

     rx_csum_none: 0

     rx_csum_complete: 3

     rx_csum_error: 0



Driver queue specific::



     tx_0_pkts: 3

     tx_0_bytes: 294

     tx_0_clean: 3

     tx_0_dma_map_err: 0

     tx_0_linearize: 0

     tx_0_frags: 0

     tx_0_tso: 0

     tx_0_tso_bytes: 0

     tx_0_csum_none: 3

     tx_0_csum: 0

     tx_0_vlan_inserted: 0

     rx_0_pkts: 2

     rx_0_bytes: 120

     rx_0_dma_map_err: 0

     rx_0_alloc_err: 0

     rx_0_csum_none: 0

     rx_0_csum_complete: 0

     rx_0_csum_error: 0

     rx_0_dropped: 0

     rx_0_vlan_stripped: 0



Firmware port specific::



     hw_tx_dropped: 0

     hw_rx_dropped: 0

     hw_rx_over_errors: 0

     hw_rx_missed_errors: 0

     hw_tx_aborted_errors: 0

     frames_rx_ok: 15

     frames_rx_all: 15

     frames_rx_bad_fcs: 0

     frames_rx_bad_all: 0

     octets_rx_ok: 1290

     octets_rx_all: 1290

     frames_rx_unicast: 10

     frames_rx_multicast: 5

     frames_rx_broadcast: 0

     frames_rx_pause: 0

     frames_rx_bad_length: 0

     frames_rx_undersized: 0

     frames_rx_oversized: 0

     frames_rx_fragments: 0

     frames_rx_jabber: 0

     frames_rx_pripause: 0

     frames_rx_stomped_crc: 0

     frames_rx_too_long: 0

     frames_rx_vlan_good: 3

     frames_rx_dropped: 0

     frames_rx_less_than_64b: 0

     frames_rx_64b: 4

     frames_rx_65b_127b: 11

     frames_rx_128b_255b: 0

     frames_rx_256b_511b: 0

     frames_rx_512b_1023b: 0

     frames_rx_1024b_1518b: 0

     frames_rx_1519b_2047b: 0

     frames_rx_2048b_4095b: 0

     frames_rx_4096b_8191b: 0

     frames_rx_8192b_9215b: 0

     frames_rx_other: 0

     frames_tx_ok: 31

     frames_tx_all: 31

     frames_tx_bad: 0

     octets_tx_ok: 2614

     octets_tx_total: 2614

     frames_tx_unicast: 8

     frames_tx_multicast: 21

     frames_tx_broadcast: 2

     frames_tx_pause: 0

     frames_tx_pripause: 0

     frames_tx_vlan: 0

     frames_tx_less_than_64b: 0

     frames_tx_64b: 4

     frames_tx_65b_127b: 27

     frames_tx_128b_255b: 0

     frames_tx_256b_511b: 0

     frames_tx_512b_1023b: 0

     frames_tx_1024b_1518b: 0

     frames_tx_1519b_2047b: 0

     frames_tx_2048b_4095b: 0

     frames_tx_4096b_8191b: 0

     frames_tx_8192b_9215b: 0

     frames_tx_other: 0

     frames_tx_pri_0: 0

     frames_tx_pri_1: 0

     frames_tx_pri_2: 0

     frames_tx_pri_3: 0

     frames_tx_pri_4: 0

     frames_tx_pri_5: 0

     frames_tx_pri_6: 0

     frames_tx_pri_7: 0

     frames_rx_pri_0: 0

     frames_rx_pri_1: 0

     frames_rx_pri_2: 0

     frames_rx_pri_3: 0

     frames_rx_pri_4: 0

     frames_rx_pri_5: 0

     frames_rx_pri_6: 0

     frames_rx_pri_7: 0

     tx_pripause_0_1us_count: 0

     tx_pripause_1_1us_count: 0

     tx_pripause_2_1us_count: 0

     tx_pripause_3_1us_count: 0

     tx_pripause_4_1us_count: 0

     tx_pripause_5_1us_count: 0

     tx_pripause_6_1us_count: 0

     tx_pripause_7_1us_count: 0

     rx_pripause_0_1us_count: 0

     rx_pripause_1_1us_count: 0

     rx_pripause_2_1us_count: 0

     rx_pripause_3_1us_count: 0

     rx_pripause_4_1us_count: 0

     rx_pripause_5_1us_count: 0

     rx_pripause_6_1us_count: 0

     rx_pripause_7_1us_count: 0

     rx_pause_1us_count: 0

     frames_tx_truncated: 0





Support

=======



For general Linux networking support, please use the netdev mailing

list, which is monitored by Pensando personnel::

drivers/net/ethernet/pensando/ionic/ionic_dev.c

+14 −0
Original line number Diff line number Diff line
@@ -388,6 +388,19 @@ int ionic_set_vf_config(struct ionic *ionic, int vf, u8 attr, u8 *data) 
}



/* LIF commands */

void ionic_dev_cmd_queue_identify(struct ionic_dev *idev,

				  u16 lif_type, u8 qtype, u8 qver)

{

	union ionic_dev_cmd cmd = {

		.q_identify.opcode = IONIC_CMD_Q_IDENTIFY,

		.q_identify.lif_type = lif_type,

		.q_identify.type = qtype,

		.q_identify.ver = qver,

	};



	ionic_dev_cmd_go(idev, &cmd);

}



void ionic_dev_cmd_lif_identify(struct ionic_dev *idev, u8 type, u8 ver)

{

	union ionic_dev_cmd cmd = {
@@ -431,6 +444,7 @@ void ionic_dev_cmd_adminq_init(struct ionic_dev *idev, struct ionic_qcq *qcq, 
		.q_init.opcode = IONIC_CMD_Q_INIT,

		.q_init.lif_index = cpu_to_le16(lif_index),

		.q_init.type = q->type,

		.q_init.ver = qcq->q.lif->qtype_info[q->type].version,

		.q_init.index = cpu_to_le32(q->index),

		.q_init.flags = cpu_to_le16(IONIC_QINIT_F_IRQ |

					    IONIC_QINIT_F_ENA),

drivers/net/ethernet/pensando/ionic/ionic_dev.h

+11 −6
Original line number Diff line number Diff line
@@ -12,7 +12,8 @@ 


#define IONIC_MIN_MTU			ETH_MIN_MTU

#define IONIC_MAX_MTU			9194

#define IONIC_MAX_TXRX_DESC		16384

#define IONIC_MAX_TX_DESC		8192

#define IONIC_MAX_RX_DESC		16384

#define IONIC_MIN_TXRX_DESC		16

#define IONIC_DEF_TXRX_DESC		4096

#define IONIC_LIFS_MAX			1024
@@ -83,6 +84,8 @@ static_assert(sizeof(struct ionic_q_init_cmd) == 64); 
static_assert(sizeof(struct ionic_q_init_comp) == 16);

static_assert(sizeof(struct ionic_q_control_cmd) == 64);

static_assert(sizeof(ionic_q_control_comp) == 16);

static_assert(sizeof(struct ionic_q_identify_cmd) == 64);

static_assert(sizeof(struct ionic_q_identify_comp) == 16);



static_assert(sizeof(struct ionic_rx_mode_set_cmd) == 64);

static_assert(sizeof(ionic_rx_mode_set_comp) == 16);
@@ -179,7 +182,7 @@ struct ionic_desc_info { 
	void *cb_arg;

};



#define QUEUE_NAME_MAX_SZ		32

#define IONIC_QUEUE_NAME_MAX_SZ		32



struct ionic_queue {

	u64 dbell_count;
@@ -204,14 +207,14 @@ struct ionic_queue { 
	unsigned int desc_size;

	unsigned int sg_desc_size;

	unsigned int pid;

	char name[QUEUE_NAME_MAX_SZ];

	char name[IONIC_QUEUE_NAME_MAX_SZ];

};



#define INTR_INDEX_NOT_ASSIGNED		-1

#define INTR_NAME_MAX_SZ		32

#define IONIC_INTR_INDEX_NOT_ASSIGNED	-1

#define IONIC_INTR_NAME_MAX_SZ		32



struct ionic_intr_info {

	char name[INTR_NAME_MAX_SZ];

	char name[IONIC_INTR_NAME_MAX_SZ];

	unsigned int index;

	unsigned int vector;

	u64 rearm_count;
@@ -283,6 +286,8 @@ void ionic_dev_cmd_port_fec(struct ionic_dev *idev, u8 fec_type); 
void ionic_dev_cmd_port_pause(struct ionic_dev *idev, u8 pause_type);



int ionic_set_vf_config(struct ionic *ionic, int vf, u8 attr, u8 *data);

void ionic_dev_cmd_queue_identify(struct ionic_dev *idev,

				  u16 lif_type, u8 qtype, u8 qver);

void ionic_dev_cmd_lif_identify(struct ionic_dev *idev, u8 type, u8 ver);

void ionic_dev_cmd_lif_init(struct ionic_dev *idev, u16 lif_index,

			    dma_addr_t addr);

drivers/net/ethernet/pensando/ionic/ionic_ethtool.c

+12 −8
Original line number Diff line number Diff line
@@ -12,10 +12,11 @@ 
#include "ionic_stats.h"



static const char ionic_priv_flags_strings[][ETH_GSTRING_LEN] = {

#define PRIV_F_SW_DBG_STATS		BIT(0)

#define IONIC_PRIV_F_SW_DBG_STATS	BIT(0)

	"sw-dbg-stats",

};

#define PRIV_FLAGS_COUNT ARRAY_SIZE(ionic_priv_flags_strings)



#define IONIC_PRIV_FLAGS_COUNT ARRAY_SIZE(ionic_priv_flags_strings)



static void ionic_get_stats_strings(struct ionic_lif *lif, u8 *buf)

{
@@ -58,7 +59,7 @@ static int ionic_get_sset_count(struct net_device *netdev, int sset) 
		count = ionic_get_stats_count(lif);

		break;

	case ETH_SS_PRIV_FLAGS:

		count = PRIV_FLAGS_COUNT;

		count = IONIC_PRIV_FLAGS_COUNT;

		break;

	}

	return count;
@@ -75,7 +76,7 @@ static void ionic_get_strings(struct net_device *netdev, 
		break;

	case ETH_SS_PRIV_FLAGS:

		memcpy(buf, ionic_priv_flags_strings,

		       PRIV_FLAGS_COUNT * ETH_GSTRING_LEN);

		       IONIC_PRIV_FLAGS_COUNT * ETH_GSTRING_LEN);

		break;

	}

}
@@ -159,6 +160,8 @@ static int ionic_get_link_ksettings(struct net_device *netdev, 
		ethtool_link_ksettings_add_link_mode(ks, supported,

						     100000baseSR4_Full);

		break;

	case IONIC_XCVR_PID_QSFP_100G_CWDM4:

	case IONIC_XCVR_PID_QSFP_100G_PSM4:

	case IONIC_XCVR_PID_QSFP_100G_LR4:

		ethtool_link_ksettings_add_link_mode(ks, supported,

						     100000baseLR4_ER4_Full);
@@ -178,6 +181,7 @@ static int ionic_get_link_ksettings(struct net_device *netdev, 
		break;

	case IONIC_XCVR_PID_SFP_25GBASE_SR:

	case IONIC_XCVR_PID_SFP_25GBASE_AOC:

	case IONIC_XCVR_PID_SFP_25GBASE_ACC:

		ethtool_link_ksettings_add_link_mode(ks, supported,

						     25000baseSR_Full);

		break;
@@ -458,9 +462,9 @@ static void ionic_get_ringparam(struct net_device *netdev, 
{

	struct ionic_lif *lif = netdev_priv(netdev);



	ring->tx_max_pending = IONIC_MAX_TXRX_DESC;

	ring->tx_max_pending = IONIC_MAX_TX_DESC;

	ring->tx_pending = lif->ntxq_descs;

	ring->rx_max_pending = IONIC_MAX_TXRX_DESC;

	ring->rx_max_pending = IONIC_MAX_RX_DESC;

	ring->rx_pending = lif->nrxq_descs;

}
@@ -554,7 +558,7 @@ static u32 ionic_get_priv_flags(struct net_device *netdev) 
	u32 priv_flags = 0;



	if (test_bit(IONIC_LIF_F_SW_DEBUG_STATS, lif->state))

		priv_flags |= PRIV_F_SW_DBG_STATS;

		priv_flags |= IONIC_PRIV_F_SW_DBG_STATS;



	return priv_flags;

}
@@ -564,7 +568,7 @@ static int ionic_set_priv_flags(struct net_device *netdev, u32 priv_flags) 
	struct ionic_lif *lif = netdev_priv(netdev);



	clear_bit(IONIC_LIF_F_SW_DEBUG_STATS, lif->state);

	if (priv_flags & PRIV_F_SW_DBG_STATS)

	if (priv_flags & IONIC_PRIV_F_SW_DBG_STATS)

		set_bit(IONIC_LIF_F_SW_DEBUG_STATS, lif->state);



	return 0;

drivers/net/ethernet/pensando/ionic/ionic_if.h

+672 −417

File changed.

Preview size limit exceeded, changes collapsed.