Commit 92a563fc authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Bjorn Andersson
Browse files

soc: qcom: ocmem: Fix refcount leak in of_get_ocmem 



of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
of_node_put() will check NULL pointer.

Fixes: 88c1e940 ("soc: qcom: add OCMEM driver")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarBrian Masney <masneyb@onstation.org>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220602042430.1114-1-linmq006@gmail.com
parent 99e7e164

drivers/soc/qcom/ocmem.c

+3 −0
Original line number Diff line number Diff line
@@ -194,14 +194,17 @@ struct ocmem *of_get_ocmem(struct device *dev) 
	devnode = of_parse_phandle(dev->of_node, "sram", 0);

	if (!devnode || !devnode->parent) {

		dev_err(dev, "Cannot look up sram phandle\n");

		of_node_put(devnode);

		return ERR_PTR(-ENODEV);

	}



	pdev = of_find_device_by_node(devnode->parent);

	if (!pdev) {

		dev_err(dev, "Cannot find device node %s\n", devnode->name);

		of_node_put(devnode);

		return ERR_PTR(-EPROBE_DEFER);

	}

	of_node_put(devnode);



	ocmem = platform_get_drvdata(pdev);

	if (!ocmem) {