Commit 928345c0 authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

mlxsw: spectrum_span: On policer_id_base_ref_count, use dec_and_test 



When unsetting policer base, the SPAN code currently uses refcount_dec().
However that function splats when the counter reaches zero, because
reaching zero without actually testing is in general indicative of a
missing cleanup. There is no cleanup to be done here, but nonetheless, use
refcount_dec_and_test() as required.

Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Reviewed-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 76ba292c

drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c

+2 −1
Original line number Diff line number Diff line
@@ -837,7 +837,8 @@ static int mlxsw_sp_span_policer_id_base_set(struct mlxsw_sp_span *span, 


static void mlxsw_sp_span_policer_id_base_unset(struct mlxsw_sp_span *span)

{

	refcount_dec(&span->policer_id_base_ref_count);

	if (refcount_dec_and_test(&span->policer_id_base_ref_count))

		span->policer_id_base = 0;

}



static struct mlxsw_sp_span_entry *