Commit 926b83e5 authored by Chunfeng Yun's avatar Chunfeng Yun Committed by Vinod Koul
Browse files

phy: phy-mtk-tphy: print error log using child device 



Print error log using child devices instead of parent device.

Signed-off-by: default avatarChunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/1629191987-20774-4-git-send-email-chunfeng.yun@mediatek.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 39099a44

drivers/phy/mediatek/phy-mtk-tphy.c

+6 −4
Original line number Diff line number Diff line
@@ -1278,6 +1278,7 @@ static int mtk_tphy_probe(struct platform_device *pdev) 
	for_each_child_of_node(np, child_np) {

		struct mtk_phy_instance *instance;

		struct clk_bulk_data *clks;

		struct device *subdev;

		struct phy *phy;



		instance = devm_kzalloc(dev, sizeof(*instance), GFP_KERNEL);
@@ -1295,16 +1296,17 @@ static int mtk_tphy_probe(struct platform_device *pdev) 
			goto put_child;

		}



		subdev = &phy->dev;

		retval = of_address_to_resource(child_np, 0, &res);

		if (retval) {

			dev_err(dev, "failed to get address resource(id-%d)\n",

			dev_err(subdev, "failed to get address resource(id-%d)\n",

				port);

			goto put_child;

		}



		instance->port_base = devm_ioremap_resource(&phy->dev, &res);

		instance->port_base = devm_ioremap_resource(subdev, &res);

		if (IS_ERR(instance->port_base)) {

			dev_err(dev, "failed to remap phy regs\n");

			dev_err(subdev, "failed to remap phy regs\n");

			retval = PTR_ERR(instance->port_base);

			goto put_child;

		}
@@ -1317,7 +1319,7 @@ static int mtk_tphy_probe(struct platform_device *pdev) 
		clks = instance->clks;

		clks[0].id = "ref";     /* digital (& analog) clock */

		clks[1].id = "da_ref";  /* analog clock */

		retval = devm_clk_bulk_get_optional(&phy->dev, TPHY_CLKS_CNT, clks);

		retval = devm_clk_bulk_get_optional(subdev, TPHY_CLKS_CNT, clks);

		if (retval)

			goto put_child;