Commit 9262793e authored by Mateusz Palczewski's avatar Mateusz Palczewski Committed by Tony Nguyen
Browse files

i40e: Fix autoneg disabling for non-10GBaseT links 



Disabling autonegotiation was allowed only for 10GBaseT PHY.
The condition was changed to check if link media type is BaseT.

Fixes: 3ce12ee9 ("i40e: Fix order of checks when enabling/disabling autoneg in ethtool")
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: default avatarKaren Sornek <karen.sornek@intel.com>
Signed-off-by: default avatarDawid Lukwinski <dawid.lukwinski@intel.com>
Signed-off-by: default avatarMateusz Palczewski <mateusz.palczewski@intel.com>
Tested-by: default avatarTony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 9c04cfcd

drivers/net/ethernet/intel/i40e/i40e_ethtool.c

+1 −2
Original line number Diff line number Diff line
@@ -1262,8 +1262,7 @@ static int i40e_set_link_ksettings(struct net_device *netdev, 
			if (ethtool_link_ksettings_test_link_mode(&safe_ks,

								  supported,

								  Autoneg) &&

			    hw->phy.link_info.phy_type !=

			    I40E_PHY_TYPE_10GBASE_T) {

			    hw->phy.media_type != I40E_MEDIA_TYPE_BASET) {

				netdev_info(netdev, "Autoneg cannot be disabled on this phy\n");

				err = -EINVAL;

				goto done;