Commit 924b2906 authored by Stephen Hemminger's avatar Stephen Hemminger Committed by Steffen Klassert
Browse files

xfrm: convert alg_key to flexible array member 



Iproute2 build generates a warning when built with gcc-12.
This is because the alg_key in xfrm.h API has zero size
array element instead of flexible array.

    CC       xfrm_state.o
In function ‘xfrm_algo_parse’,
    inlined from ‘xfrm_state_modify.constprop’ at xfrm_state.c:573:5:
xfrm_state.c:162:32: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
  162 |                         buf[j] = val;
      |                         ~~~~~~~^~~~~

This patch convert the alg_key into flexible array member.
There are other zero size arrays here that should be converted as
well.

This patch is RFC only since it is only compile tested and
passes trivial iproute2 tests.

Signed-off-by: default avatarStephen Hemminger <stephen@networkplumber.org>
Acked-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent b5c8b3fe

include/uapi/linux/xfrm.h

+3 −3
Original line number Diff line number Diff line
@@ -102,21 +102,21 @@ struct xfrm_replay_state_esn { 
struct xfrm_algo {

	char		alg_name[64];

	unsigned int	alg_key_len;    /* in bits */

	char		alg_key[0];

	char		alg_key[];

};



struct xfrm_algo_auth {

	char		alg_name[64];

	unsigned int	alg_key_len;    /* in bits */

	unsigned int	alg_trunc_len;  /* in bits */

	char		alg_key[0];

	char		alg_key[];

};



struct xfrm_algo_aead {

	char		alg_name[64];

	unsigned int	alg_key_len;	/* in bits */

	unsigned int	alg_icv_len;	/* in bits */

	char		alg_key[0];

	char		alg_key[];

};



struct xfrm_stats {