Commit 924a07e4 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: refactor io_submit_sqe() 



Remove one extra if for non-linked path of io_submit_sqe().

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/03183199d1bf494b4a72eca16d792c8a5945acb4.1650056133.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent df3becde

fs/io_uring.c

+14 −9
Original line number Diff line number Diff line
@@ -7765,7 +7765,7 @@ static inline int io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req, 
	 * submitted sync once the chain is complete. If none of those

	 * conditions are true (normal request), then just queue it.

	 */

	if (link->head) {

	if (unlikely(link->head)) {

		ret = io_req_prep_async(req);

		if (unlikely(ret))

			return io_submit_fail_init(sqe, req, ret);
@@ -7779,17 +7779,22 @@ static inline int io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req, 
		/* last request of the link, flush it */

		req = link->head;

		link->head = NULL;

	} else if (req->flags & IO_REQ_LINK_FLAGS) {

		if (req->flags & (REQ_F_FORCE_ASYNC | REQ_F_FAIL))

			goto fallback;



	} else if (unlikely(req->flags & (IO_REQ_LINK_FLAGS |

					  REQ_F_FORCE_ASYNC | REQ_F_FAIL))) {

		if (req->flags & IO_REQ_LINK_FLAGS) {

			link->head = req;

			link->last = req;

		} else {

fallback:

			io_queue_sqe_fallback(req);

		}

		return 0;

	}



	if (likely(!(req->flags & (REQ_F_FORCE_ASYNC | REQ_F_FAIL))))

	io_queue_sqe(req);

	else

		io_queue_sqe_fallback(req);



	return 0;

}