Commit 9243eadc authored by Stephen Boyd's avatar Stephen Boyd Committed by Rob Herring
Browse files

usb: usb251xb: Use of_device_get_match_data() 



Use the more modern API here instead of using of_match_device() and
avoid casting away const from the returned pointer by pushing the const
type through to the users. This nicely avoids referencing the match
table when it is undefined with configurations where CONFIG_OF=n and
avoids const issues.

Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Richard Leitner <richard.leitner@skidata.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: <linux-usb@vger.kernel.org>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20210123034428.2841052-5-swboyd@chromium.org
parent d825f0be

drivers/usb/misc/usb251xb.c

+5 −7
Original line number Diff line number Diff line
@@ -396,7 +396,7 @@ static void usb251xb_get_ports_field(struct usb251xb *hub, 
}



static int usb251xb_get_ofdata(struct usb251xb *hub,

			       struct usb251xb_data *data)

			       const struct usb251xb_data *data)

{

	struct device *dev = hub->dev;

	struct device_node *np = dev->of_node;
@@ -630,7 +630,7 @@ static const struct of_device_id usb251xb_of_match[] = { 
MODULE_DEVICE_TABLE(of, usb251xb_of_match);

#else /* CONFIG_OF */

static int usb251xb_get_ofdata(struct usb251xb *hub,

			       struct usb251xb_data *data)

			       const struct usb251xb_data *data)

{

	return 0;

}
@@ -647,13 +647,11 @@ static int usb251xb_probe(struct usb251xb *hub) 
{

	struct device *dev = hub->dev;

	struct device_node *np = dev->of_node;

	const struct of_device_id *of_id = of_match_device(usb251xb_of_match,

							   dev);

	const struct usb251xb_data *usb_data = of_device_get_match_data(dev);

	int err;



	if (np && of_id) {

		err = usb251xb_get_ofdata(hub,

					  (struct usb251xb_data *)of_id->data);

	if (np && usb_data) {

		err = usb251xb_get_ofdata(hub, usb_data);

		if (err) {

			dev_err(dev, "failed to get ofdata: %d\n", err);

			return err;