Commit 922f2a7c authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jessica Yu
Browse files

module: mark module_mutex static 



Except for two lockdep asserts module_mutex is only used in module.c.
Remove the two asserts given that the functions they are in are not
exported and just called from the module code, and mark module_mutex
static.

Reviewed-by: default avatarMiroslav Benes <mbenes@suse.cz>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJessica Yu <jeyu@kernel.org>
parent 3e355205

include/linux/module.h

+0 −2
Original line number Diff line number Diff line
@@ -550,8 +550,6 @@ static inline unsigned long kallsyms_symbol_value(const Elf_Sym *sym) 
}

#endif



extern struct mutex module_mutex;



/* FIXME: It'd be nice to isolate modules during init, too, so they

   aren't used before they (may) fail.  But presently too much code

   (IDE & SCSI) require entry into the module during init.*/

kernel/module.c

+1 −1
Original line number Diff line number Diff line
@@ -87,7 +87,7 @@ 
 * 3) module_addr_min/module_addr_max.

 * (delete and add uses RCU list operations).

 */

DEFINE_MUTEX(module_mutex);

static DEFINE_MUTEX(module_mutex);

static LIST_HEAD(modules);



/* Work queue for freeing init sections in success case */

lib/bug.c

+0 −3
Original line number Diff line number Diff line
@@ -91,8 +91,6 @@ void module_bug_finalize(const Elf_Ehdr *hdr, const Elf_Shdr *sechdrs, 
	char *secstrings;

	unsigned int i;



	lockdep_assert_held(&module_mutex);



	mod->bug_table = NULL;

	mod->num_bugs = 0;
@@ -118,7 +116,6 @@ void module_bug_finalize(const Elf_Ehdr *hdr, const Elf_Shdr *sechdrs, 


void module_bug_cleanup(struct module *mod)

{

	lockdep_assert_held(&module_mutex);

	list_del_rcu(&mod->bug_list);

}