Commit 9228742c authored by Deepak R Varma's avatar Deepak R Varma Committed by Lyude Paul
Browse files

drm/nouveau/hwmon: Use sysfs_emit in show function callsbacks 



According to Documentation/filesystems/sysfs.rst, the show() callback
function of kobject attributes should strictly use sysfs_emit() instead
of sprintf() family functions. So, make this change.
Issue identified using the coccinelle device_attr_show.cocci script.

Signed-off-by: default avatarDeepak R Varma <drv@mailo.com>
Reviewed-by: default avatarAshutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/Y/+pDaHOgG1x8Py2@ubun2204.myguest.virtualbox.org
parent aad9729e

drivers/gpu/drm/nouveau/nouveau_hwmon.c

+5 −5
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ static ssize_t 
nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d,

					 struct device_attribute *a, char *buf)

{

	return snprintf(buf, PAGE_SIZE, "%d\n", 100);

	return sysfs_emit(buf, "%d\n", 100);

}

static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444,

			  nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0);
@@ -54,7 +54,7 @@ nouveau_hwmon_temp1_auto_point1_temp(struct device *d, 
	struct nouveau_drm *drm = nouveau_drm(dev);

	struct nvkm_therm *therm = nvxx_therm(&drm->client.device);



	return snprintf(buf, PAGE_SIZE, "%d\n",

	return sysfs_emit(buf, "%d\n",

			  therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST) * 1000);

}

static ssize_t
@@ -87,7 +87,7 @@ nouveau_hwmon_temp1_auto_point1_temp_hyst(struct device *d, 
	struct nouveau_drm *drm = nouveau_drm(dev);

	struct nvkm_therm *therm = nvxx_therm(&drm->client.device);



	return snprintf(buf, PAGE_SIZE, "%d\n",

	return sysfs_emit(buf, "%d\n",

			  therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST_HYST) * 1000);

}

static ssize_t