Commit 921d161f authored by Tong Tiangen's avatar Tong Tiangen Committed by Catalin Marinas
Browse files

arm64: fix types in copy_highpage()



In copy_highpage() the `kto` and `kfrom` local variables are pointers to
struct page, but these are used to hold arbitrary pointers to kernel memory
. Each call to page_address() returns a void pointer to memory associated
with the relevant page, and copy_page() expects void pointers to this
memory.

This inconsistency was introduced in commit 2563776b ("arm64: mte:
Tags-aware copy_{user_,}highpage() implementations") and while this
doesn't appear to be harmful in practice it is clearly wrong.

Correct this by making `kto` and `kfrom` void pointers.

Fixes: 2563776b ("arm64: mte: Tags-aware copy_{user_,}highpage() implementations")
Signed-off-by: default avatarTong Tiangen <tongtiangen@huawei.com>
Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
Reviewed-by: default avatarKefeng Wang <wangkefeng.wang@huawei.com>
Link: https://lore.kernel.org/r/20220420030418.3189040-3-tongtiangen@huawei.com


Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 5028fbad
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -16,8 +16,8 @@

void copy_highpage(struct page *to, struct page *from)
{
	struct page *kto = page_address(to);
	struct page *kfrom = page_address(from);
	void *kto = page_address(to);
	void *kfrom = page_address(from);

	copy_page(kto, kfrom);