Commit 9208f7bf authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Marc Kleine-Budde
Browse files

can: softing: Remove redundant variable ptr 

The value stored to ptr in the calculations this patch removes is not
used, so the calculation and the assignment can be removed.

Cleans up the following clang-analyzer warning:

drivers/net/can/softing/softing_main.c:279:3: warning: Value stored to
'ptr' is never read [clang-analyzer-deadcode.DeadStores].

drivers/net/can/softing/softing_main.c:242:3: warning: Value stored to
'ptr' is never read [clang-analyzer-deadcode.DeadStores].

Link: https://lore.kernel.org/r/1619520767-80948-1-git-send-email-jiapeng.chong@linux.alibaba.com


Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent c69d190f

drivers/net/can/softing/softing_main.c

+0 −2
Original line number Diff line number Diff line
@@ -239,7 +239,6 @@ static int softing_handle_1(struct softing *card) 
				DPRAM_INFO_BUSSTATE2 : DPRAM_INFO_BUSSTATE]);

		/* timestamp */

		tmp_u32 = le32_to_cpup((void *)ptr);

		ptr += 4;

		ktime = softing_raw2ktime(card, tmp_u32);



		++netdev->stats.rx_errors;
@@ -276,7 +275,6 @@ static int softing_handle_1(struct softing *card) 
		ktime = softing_raw2ktime(card, tmp_u32);

		if (!(msg.can_id & CAN_RTR_FLAG))

			memcpy(&msg.data[0], ptr, 8);

		ptr += 8;

		/* update socket */

		if (cmd & CMD_ACK) {

			/* acknowledge, was tx msg */