Commit 91e6455b authored by Liang He's avatar Liang He Committed by Stephen Boyd
Browse files

clk: sprd: Hold reference returned by of_get_parent() 



We should hold the reference returned by of_get_parent() and use it
to call of_node_put() for refcount balance.

Fixes: f95e8c79 ("clk: sprd: support to get regmap from parent node")
Signed-off-by: default avatarLiang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220704004729.272481-1-windhl@126.com


Reviewed-by: default avatarOrson Zhai <orsonzhai@gmail.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 37c381b8

drivers/clk/sprd/common.c

+5 −4
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev, 
{

	void __iomem *base;

	struct device *dev = &pdev->dev;

	struct device_node *node = dev->of_node;

	struct device_node *node = dev->of_node, *np;

	struct regmap *regmap;



	if (of_find_property(node, "sprd,syscon", NULL)) {
@@ -50,9 +50,10 @@ int sprd_clk_regmap_init(struct platform_device *pdev, 
			pr_err("%s: failed to get syscon regmap\n", __func__);

			return PTR_ERR(regmap);

		}

	} else if (of_device_is_compatible(of_get_parent(dev->of_node),

			   "syscon")) {

		regmap = device_node_to_regmap(of_get_parent(dev->of_node));

	} else if (of_device_is_compatible(np =	of_get_parent(node), "syscon") ||

		   (of_node_put(np), 0)) {

		regmap = device_node_to_regmap(np);

		of_node_put(np);

		if (IS_ERR(regmap)) {

			dev_err(dev, "failed to get regmap from its parent.\n");

			return PTR_ERR(regmap);