Commit 91c71bf1 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Paolo Abeni
Browse files

net: dpaa2-eth: don't use -ENOTSUPP error code 



dpaa2_eth_setup_dpni() is called from the probe path and
dpaa2_eth_set_link_ksettings() is propagated to user space.

include/linux/errno.h says that ENOTSUPP is "Defined for the NFSv3
protocol". Conventional wisdom has it to not use it in networking
drivers. Replace it with -EOPNOTSUPP.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Tested-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 682f560b

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c

+1 −1
Original line number Diff line number Diff line
@@ -3791,7 +3791,7 @@ static int dpaa2_eth_setup_dpni(struct fsl_mc_device *ls_dev) 
		dev_err(dev, "DPNI version %u.%u not supported, need >= %u.%u\n",

			priv->dpni_ver_major, priv->dpni_ver_minor,

			DPNI_VER_MAJOR, DPNI_VER_MINOR);

		err = -ENOTSUPP;

		err = -EOPNOTSUPP;

		goto close;

	}

drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c

+1 −1
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ dpaa2_eth_set_link_ksettings(struct net_device *net_dev, 
	struct dpaa2_eth_priv *priv = netdev_priv(net_dev);



	if (!dpaa2_eth_is_type_phy(priv))

		return -ENOTSUPP;

		return -EOPNOTSUPP;



	return phylink_ethtool_ksettings_set(priv->mac->phylink, link_settings);

}