Commit 91bc0d52 authored by Jian Shen's avatar Jian Shen Committed by David S. Miller
Browse files

net: hns3: fix inconsistent vf id print 



The vf id from ethtool is added 1 before configured to driver.
So it's necessary to minus 1 when printing it, in order to
keep consistent with user's configuration.

Fixes: dd74f815 ("net: hns3: Add support for rule add/delete for flow director")
Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarGuangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e184cec5

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+5 −2
Original line number Diff line number Diff line
@@ -6642,10 +6642,13 @@ static int hclge_fd_parse_ring_cookie(struct hclge_dev *hdev, u64 ring_cookie, 
		u8 vf = ethtool_get_flow_spec_ring_vf(ring_cookie);

		u16 tqps;



		/* To keep consistent with user's configuration, minus 1 when

		 * printing 'vf', because vf id from ethtool is added 1 for vf.

		 */

		if (vf > hdev->num_req_vfs) {

			dev_err(&hdev->pdev->dev,

				"Error: vf id (%u) > max vf num (%u)\n",

				vf, hdev->num_req_vfs);

				"Error: vf id (%u) should be less than %u\n",

				vf - 1, hdev->num_req_vfs);

			return -EINVAL;

		}