Commit 91b1ad08 authored by Jingbo Xu's avatar Jingbo Xu Committed by Gao Xiang
Browse files

erofs: release ztailpacking pclusters properly 



Currently ztailpacking pclusters are chained with FOLLOWED_NOINPLACE and
not recorded into the managed_pslots XArray.

After commit 7674a42f ("erofs: use struct lockref to replace
handcrafted approach"), ztailpacking pclusters won't be freed with
erofs_workgroup_put() anymore, which will cause the following issue:

BUG erofs_pcluster-1 (Tainted: G           OE     ): Objects remaining in erofs_pcluster-1 on __kmem_cache_shutdown()

Use z_erofs_free_pcluster() directly to free ztailpacking pclusters.

Fixes: 7674a42f ("erofs: use struct lockref to replace handcrafted approach")
Signed-off-by: default avatarJingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: default avatarChao Yu <chao@kernel.org>
Link: https://lore.kernel.org/r/20230822110530.96831-1-jefflexu@linux.alibaba.com


Signed-off-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
parent 5ec693ca

fs/erofs/zdata.c

+4 −1
Original line number Diff line number Diff line
@@ -1369,6 +1369,9 @@ static void z_erofs_decompress_queue(const struct z_erofs_decompressqueue *io, 
		owned = READ_ONCE(be.pcl->next);



		z_erofs_decompress_pcluster(&be, io->eio ? -EIO : 0);

		if (z_erofs_is_inline_pcluster(be.pcl))

			z_erofs_free_pcluster(be.pcl);

		else

			erofs_workgroup_put(&be.pcl->obj);

	}

}