Commit 91875c22 authored by Tvrtko Ursulin's avatar Tvrtko Ursulin
Browse files

drm/i915: Don't use DRM_DEBUG_WARN_ON for ring unexpectedly not idle 



DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed
to exercise a certain code path, so in case of values coming from MMIO
reads we cannot be sure CI will have all the possible SKUs and parts, or
that it will catch all possible error conditions. Use drm_warn instead.

Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: default avatarMika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220505110007.943449-2-tvrtko.ursulin@linux.intel.com
parent e6c2db2b

drivers/gpu/drm/i915/gt/intel_ring_submission.c

+3 −1
Original line number Diff line number Diff line
@@ -117,7 +117,9 @@ static void flush_cs_tlb(struct intel_engine_cs *engine) 
		return;



	/* ring should be idle before issuing a sync flush*/

	GEM_DEBUG_WARN_ON((ENGINE_READ(engine, RING_MI_MODE) & MODE_IDLE) == 0);

	if ((ENGINE_READ(engine, RING_MI_MODE) & MODE_IDLE) == 0)

		drm_warn(&engine->i915->drm, "%s not idle before sync flush!\n",

			 engine->name);



	ENGINE_WRITE_FW(engine, RING_INSTPM,

			_MASKED_BIT_ENABLE(INSTPM_TLB_INVALIDATE |