Commit 9168d125 authored by Bob Pearson's avatar Bob Pearson Committed by Jason Gunthorpe
Browse files

RDMA/rxe: Replace exists by rxe in rxe.c 

'exists' looks like a boolean. This patch replaces it by the
normal name used for the rxe device, 'rxe', which should be a
little less confusing. The second rxe_dbg() message is
incorrect since rxe is known to be NULL and this will cause a
seg fault if this message were ever sent. Replace it by pr_debug
for the moment.

Fixes: c6aba5ea ("RDMA/rxe: Replace pr_xxx by rxe_dbg_xxx in rxe.c")
Link: https://lore.kernel.org/r/20230303221623.8053-2-rpearsonhpe@gmail.com


Signed-off-by: default avatarBob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent aa4d540b

drivers/infiniband/sw/rxe/rxe.c

+6 −6
Original line number Diff line number Diff line
@@ -175,7 +175,7 @@ int rxe_add(struct rxe_dev *rxe, unsigned int mtu, const char *ibdev_name) 


static int rxe_newlink(const char *ibdev_name, struct net_device *ndev)

{

	struct rxe_dev *exists;

	struct rxe_dev *rxe;

	int err = 0;



	if (is_vlan_dev(ndev)) {
@@ -184,17 +184,17 @@ static int rxe_newlink(const char *ibdev_name, struct net_device *ndev) 
		goto err;

	}



	exists = rxe_get_dev_from_net(ndev);

	if (exists) {

		ib_device_put(&exists->ib_dev);

		rxe_dbg(exists, "already configured on %s\n", ndev->name);

	rxe = rxe_get_dev_from_net(ndev);

	if (rxe) {

		ib_device_put(&rxe->ib_dev);

		rxe_dbg(rxe, "already configured on %s\n", ndev->name);

		err = -EEXIST;

		goto err;

	}



	err = rxe_net_add(ibdev_name, ndev);

	if (err) {

		rxe_dbg(exists, "failed to add %s\n", ndev->name);

		pr_debug("failed to add %s\n", ndev->name);

		goto err;

	}

err: