Unverified Commit 91686a39 authored by Lad Prabhakar's avatar Lad Prabhakar Committed by Mark Brown
Browse files

ASoC: sh: rz-ssi: Propagate error codes returned from platform_get_irq_byname() 



Propagate error codes returned from platform_get_irq_byname() instead of
returning -ENODEV. platform_get_irq_byname() may return -EPROBE_DEFER, to
handle such cases propagate the error codes.

While at it drop the dev_err_probe() messages as platform_get_irq_byname()
already does this for us in case of error.

Signed-off-by: default avatarLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/r/20220426074922.13319-3-prabhakar.mahadev-lad.rj@bp.renesas.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 17a1fef5

sound/soc/sh/rz-ssi.c

+3 −6
Original line number Diff line number Diff line
@@ -977,8 +977,7 @@ static int rz_ssi_probe(struct platform_device *pdev) 
	/* Error Interrupt */

	ssi->irq_int = platform_get_irq_byname(pdev, "int_req");

	if (ssi->irq_int < 0)

		return dev_err_probe(&pdev->dev, -ENODEV,

				     "Unable to get SSI int_req IRQ\n");

		return ssi->irq_int;



	ret = devm_request_irq(&pdev->dev, ssi->irq_int, &rz_ssi_interrupt,

			       0, dev_name(&pdev->dev), ssi);
@@ -990,8 +989,7 @@ static int rz_ssi_probe(struct platform_device *pdev) 
		/* Tx and Rx interrupts (pio only) */

		ssi->irq_tx = platform_get_irq_byname(pdev, "dma_tx");

		if (ssi->irq_tx < 0)

			return dev_err_probe(&pdev->dev, -ENODEV,

					     "Unable to get SSI dma_tx IRQ\n");

			return ssi->irq_tx;



		ret = devm_request_irq(&pdev->dev, ssi->irq_tx,

				       &rz_ssi_interrupt, 0,
@@ -1002,8 +1000,7 @@ static int rz_ssi_probe(struct platform_device *pdev) 


		ssi->irq_rx = platform_get_irq_byname(pdev, "dma_rx");

		if (ssi->irq_rx < 0)

			return dev_err_probe(&pdev->dev, -ENODEV,

					     "Unable to get SSI dma_rx IRQ\n");

			return ssi->irq_rx;



		ret = devm_request_irq(&pdev->dev, ssi->irq_rx,

				       &rz_ssi_interrupt, 0,