Commit 9167cc78 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

serial: 8250_omap: Switch to use platform_get_irq() 



platform_get_irq() provides an established error code and error message.
Also, it's better to use dedicated API to retrieve Linux IRQ resource.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200618122024.87170-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2a1dbd25

drivers/tty/serial/8250/8250_omap.c

+10 −6
Original line number Diff line number Diff line
@@ -1209,17 +1209,21 @@ MODULE_DEVICE_TABLE(of, omap8250_dt_ids); 


static int omap8250_probe(struct platform_device *pdev)

{

	struct resource *regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	struct resource *irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);

	struct device_node *np = pdev->dev.of_node;

	struct omap8250_priv *priv;

	const struct omap8250_platdata *pdata;

	struct uart_8250_port up;

	int ret;

	struct resource *regs;

	void __iomem *membase;

	int irq, ret;



	irq = platform_get_irq(pdev, 0);

	if (irq < 0)

		return irq;



	if (!regs || !irq) {

		dev_err(&pdev->dev, "missing registers or irq\n");

	regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!regs) {

		dev_err(&pdev->dev, "missing registers\n");

		return -EINVAL;

	}
@@ -1236,7 +1240,7 @@ static int omap8250_probe(struct platform_device *pdev) 
	up.port.dev = &pdev->dev;

	up.port.mapbase = regs->start;

	up.port.membase = membase;

	up.port.irq = irq->start;

	up.port.irq = irq;

	/*

	 * It claims to be 16C750 compatible however it is a little different.

	 * It has EFR and has no FCR7_64byte bit. The AFE (which it claims to