Commit 9161f365 authored by Christian Eggers's avatar Christian Eggers Committed by Miquel Raynal
Browse files

mtd: rawnand: gpmi: don't leak PM reference in error path 



If gpmi_nfc_apply_timings() fails, the PM runtime usage counter must be
dropped.

Reported-by: default avatarPavel Machek <pavel@denx.de>
Fixes: f53d4c10 ("mtd: rawnand: gpmi: Add ERR007117 protection for nfc_apply_timings")
Signed-off-by: default avatarChristian Eggers <ceggers@arri.de>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220125081619.6286-1-ceggers@arri.de
parent 3e376587

drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c

+2 −1
Original line number Diff line number Diff line
@@ -2285,7 +2285,7 @@ static int gpmi_nfc_exec_op(struct nand_chip *chip, 
		this->hw.must_apply_timings = false;

		ret = gpmi_nfc_apply_timings(this);

		if (ret)

			return ret;

			goto out_pm;

	}



	dev_dbg(this->dev, "%s: %d instructions\n", __func__, op->ninstrs);
@@ -2414,6 +2414,7 @@ static int gpmi_nfc_exec_op(struct nand_chip *chip, 


	this->bch = false;



out_pm:

	pm_runtime_mark_last_busy(this->dev);

	pm_runtime_put_autosuspend(this->dev);