Commit 9137bdf3 authored by Anna Schumaker's avatar Anna Schumaker Committed by Trond Myklebust
Browse files

NFS: Create a common results structure for reads and writes 



Reads and writes have very similar results.  This patch combines the two
structs together with comments to show where the differing fields are
used.

Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 3c6b899c

fs/nfs/nfs2xdr.c

+3 −3
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ static void print_overflow_msg(const char *func, const struct xdr_stream *xdr) 
/*

 *	typedef opaque	nfsdata<>;

 */

static int decode_nfsdata(struct xdr_stream *xdr, struct nfs_readres *result)

static int decode_nfsdata(struct xdr_stream *xdr, struct nfs_pgio_res *result)

{

	u32 recvd, count;

	__be32 *p;
@@ -857,7 +857,7 @@ static int nfs2_xdr_dec_readlinkres(struct rpc_rqst *req, 
 *	};

 */

static int nfs2_xdr_dec_readres(struct rpc_rqst *req, struct xdr_stream *xdr,

				struct nfs_readres *result)

				struct nfs_pgio_res *result)

{

	enum nfs_stat status;

	int error;
@@ -878,7 +878,7 @@ static int nfs2_xdr_dec_readres(struct rpc_rqst *req, struct xdr_stream *xdr, 
}



static int nfs2_xdr_dec_writeres(struct rpc_rqst *req, struct xdr_stream *xdr,

				 struct nfs_writeres *result)

				 struct nfs_pgio_res *result)

{

	/* All NFSv2 writes are "file sync" writes */

	result->verf->committed = NFS_FILE_SYNC;

fs/nfs/nfs3xdr.c

+4 −4
Original line number Diff line number Diff line
@@ -1589,7 +1589,7 @@ static int nfs3_xdr_dec_readlink3res(struct rpc_rqst *req, 
 *	};

 */

static int decode_read3resok(struct xdr_stream *xdr,

			     struct nfs_readres *result)

			     struct nfs_pgio_res *result)

{

	u32 eof, count, ocount, recvd;

	__be32 *p;
@@ -1625,7 +1625,7 @@ static int decode_read3resok(struct xdr_stream *xdr, 
}



static int nfs3_xdr_dec_read3res(struct rpc_rqst *req, struct xdr_stream *xdr,

				 struct nfs_readres *result)

				 struct nfs_pgio_res *result)

{

	enum nfs_stat status;

	int error;
@@ -1673,7 +1673,7 @@ static int nfs3_xdr_dec_read3res(struct rpc_rqst *req, struct xdr_stream *xdr, 
 *	};

 */

static int decode_write3resok(struct xdr_stream *xdr,

			      struct nfs_writeres *result)

			      struct nfs_pgio_res *result)

{

	__be32 *p;
@@ -1697,7 +1697,7 @@ static int decode_write3resok(struct xdr_stream *xdr, 
}



static int nfs3_xdr_dec_write3res(struct rpc_rqst *req, struct xdr_stream *xdr,

				  struct nfs_writeres *result)

				  struct nfs_pgio_res *result)

{

	enum nfs_stat status;

	int error;

fs/nfs/nfs4xdr.c

+5 −4
Original line number Diff line number Diff line
@@ -5087,7 +5087,8 @@ static int decode_putrootfh(struct xdr_stream *xdr) 
	return decode_op_hdr(xdr, OP_PUTROOTFH);

}



static int decode_read(struct xdr_stream *xdr, struct rpc_rqst *req, struct nfs_readres *res)

static int decode_read(struct xdr_stream *xdr, struct rpc_rqst *req,

		       struct nfs_pgio_res *res)

{

	__be32 *p;

	uint32_t count, eof, recvd;
@@ -5341,7 +5342,7 @@ static int decode_setclientid_confirm(struct xdr_stream *xdr) 
	return decode_op_hdr(xdr, OP_SETCLIENTID_CONFIRM);

}



static int decode_write(struct xdr_stream *xdr, struct nfs_writeres *res)

static int decode_write(struct xdr_stream *xdr, struct nfs_pgio_res *res)

{

	__be32 *p;

	int status;
@@ -6638,7 +6639,7 @@ static int nfs4_xdr_dec_readdir(struct rpc_rqst *rqstp, struct xdr_stream *xdr, 
 * Decode Read response

 */

static int nfs4_xdr_dec_read(struct rpc_rqst *rqstp, struct xdr_stream *xdr,

			     struct nfs_readres *res)

			     struct nfs_pgio_res *res)

{

	struct compound_hdr hdr;

	int status;
@@ -6663,7 +6664,7 @@ static int nfs4_xdr_dec_read(struct rpc_rqst *rqstp, struct xdr_stream *xdr, 
 * Decode WRITE response

 */

static int nfs4_xdr_dec_write(struct rpc_rqst *rqstp, struct xdr_stream *xdr,

			      struct nfs_writeres *res)

			      struct nfs_pgio_res *res)

{

	struct compound_hdr hdr;

	int status;

fs/nfs/read.c

+1 −1
Original line number Diff line number Diff line
@@ -471,7 +471,7 @@ int nfs_readpage_result(struct rpc_task *task, struct nfs_read_data *data) 
static void nfs_readpage_retry(struct rpc_task *task, struct nfs_read_data *data)

{

	struct nfs_pgio_args *argp = &data->args;

	struct nfs_readres *resp = &data->res;

	struct nfs_pgio_res  *resp = &data->res;



	/* This is a short read! */

	nfs_inc_stats(data->header->inode, NFSIOS_SHORTREAD);

fs/nfs/write.c

+1 −1
Original line number Diff line number Diff line
@@ -1389,7 +1389,7 @@ static int nfs_should_remove_suid(const struct inode *inode) 
void nfs_writeback_done(struct rpc_task *task, struct nfs_write_data *data)

{

	struct nfs_pgio_args	*argp = &data->args;

	struct nfs_writeres	*resp = &data->res;

	struct nfs_pgio_res	*resp = &data->res;

	struct inode		*inode = data->header->inode;

	int status;