Commit 9130559c authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Kalle Valo
Browse files

ipw2100: Use GFP_KERNEL instead of GFP_ATOMIC in some memory allocation 



The call chain is:
   ipw2100_pci_init_one            (the probe function)
     --> ipw2100_queues_allocate
       --> ipw2100_tx_allocate

No lock is taken in the between.
So it is safe to use GFP_KERNEL in 'ipw2100_tx_allocate()'.

BTW, 'ipw2100_queues_allocate()' also calls 'ipw2100_msg_allocate()' which
already allocates some memory using GFP_KERNEL.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200722101701.26126-1-christophe.jaillet@wanadoo.fr
parent 99aaa1aa

drivers/net/wireless/intel/ipw2x00/ipw2100.c

+1 −1
Original line number Diff line number Diff line
@@ -4430,7 +4430,7 @@ static int ipw2100_tx_allocate(struct ipw2100_priv *priv) 


	priv->tx_buffers = kmalloc_array(TX_PENDED_QUEUE_LENGTH,

					 sizeof(struct ipw2100_tx_packet),

					 GFP_ATOMIC);

					 GFP_KERNEL);

	if (!priv->tx_buffers) {

		bd_queue_free(priv, &priv->tx_queue);

		return -ENOMEM;