Commit 91019b5b authored by Breno Leitao's avatar Breno Leitao Committed by Vishal Verma
Browse files

cxl/acpi: Return 'rc' instead of '0' in cxl_parse_cfmws() 



Driver initialization returned success (return 0) even if the
initialization (cxl_decoder_add() or acpi_table_parse_cedt()) failed.

Return the error instead of swallowing it.

Fixes: f4ce1f76 ("cxl/acpi: Convert CFMWS parsing to ACPI sub-table helpers")
Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20230714093146.2253438-2-leitao@debian.org


Reviewed-by: default avatarAlison Schofield <alison.schofield@intel.com>
Signed-off-by: default avatarVishal Verma <vishal.l.verma@intel.com>
parent 4cf67d3c

drivers/cxl/acpi.c

+1 −1
Original line number Diff line number Diff line
@@ -297,7 +297,7 @@ static int cxl_parse_cfmws(union acpi_subtable_headers *header, void *arg, 
		rc = cxl_decoder_autoremove(dev, cxld);

	if (rc) {

		dev_err(dev, "Failed to add decode range: %pr", res);

		return 0;

		return rc;

	}

	dev_dbg(dev, "add: %s node: %d range [%#llx - %#llx]\n",

		dev_name(&cxld->dev),