Commit 90f5daea authored by Shayne Chen's avatar Shayne Chen Committed by Felix Fietkau
Browse files

mt76: mt7915: add debugfs knobs for MCU utilization 



Add debugfs knobs to read MCU utilization, which helps user know
firmware status more easily to narrow down CPU bottleneck issues.

Co-developed-by: default avatarRyder Lee <ryder.lee@mediatek.com>
Signed-off-by: default avatarRyder Lee <ryder.lee@mediatek.com>
Signed-off-by: default avatarShayne Chen <shayne.chen@mediatek.com>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 9b121acd

drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c

+50 −1
Original line number Diff line number Diff line
@@ -106,6 +106,12 @@ mt7915_fw_debug_wm_set(void *data, u64 val) 
			return ret;

	}



	/* WM CPU info record control */

	mt76_clear(dev, MT_CPU_UTIL_CTRL, BIT(0));

	mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | !dev->fw_debug_wm);

	mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_MASK_CLR_ADDR, BIT(5));

	mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_SOFT_ADDR, BIT(5));



	return 0;

}
@@ -126,10 +132,16 @@ static int 
mt7915_fw_debug_wa_set(void *data, u64 val)

{

	struct mt7915_dev *dev = data;

	int ret;



	dev->fw_debug_wa = val ? MCU_FW_LOG_TO_HOST : 0;



	return mt7915_mcu_fw_log_2_host(dev, MCU_FW_LOG_WA, dev->fw_debug_wa);

	ret = mt7915_mcu_fw_log_2_host(dev, MCU_FW_LOG_WA, dev->fw_debug_wa);

	if (ret)

		return ret;



	return mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(SET), MCU_WA_PARAM_PDMA_RX,

				 !!dev->fw_debug_wa, 0);

}



static int
@@ -145,6 +157,39 @@ mt7915_fw_debug_wa_get(void *data, u64 *val) 
DEFINE_DEBUGFS_ATTRIBUTE(fops_fw_debug_wa, mt7915_fw_debug_wa_get,

			 mt7915_fw_debug_wa_set, "%lld\n");



static int

mt7915_fw_util_wm_show(struct seq_file *file, void *data)

{

	struct mt7915_dev *dev = file->private;



	if (dev->fw_debug_wm) {

		seq_printf(file, "Busy: %u%%  Peak busy: %u%%\n",

			   mt76_rr(dev, MT_CPU_UTIL_BUSY_PCT),

			   mt76_rr(dev, MT_CPU_UTIL_PEAK_BUSY_PCT));

		seq_printf(file, "Idle count: %u  Peak idle count: %u\n",

			   mt76_rr(dev, MT_CPU_UTIL_IDLE_CNT),

			   mt76_rr(dev, MT_CPU_UTIL_PEAK_IDLE_CNT));

	}



	return 0;

}



DEFINE_SHOW_ATTRIBUTE(mt7915_fw_util_wm);



static int

mt7915_fw_util_wa_show(struct seq_file *file, void *data)

{

	struct mt7915_dev *dev = file->private;



	if (dev->fw_debug_wa)

		return mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(QUERY),

					 MCU_WA_PARAM_CPU_UTIL, 0, 0);



	return 0;

}



DEFINE_SHOW_ATTRIBUTE(mt7915_fw_util_wa);



static void

mt7915_ampdu_stat_read_phy(struct mt7915_phy *phy,

			   struct seq_file *file)
@@ -491,6 +536,10 @@ int mt7915_init_debugfs(struct mt7915_phy *phy) 
	debugfs_create_file("tx_stats", 0400, dir, phy, &mt7915_tx_stats_fops);

	debugfs_create_file("fw_debug_wm", 0600, dir, dev, &fops_fw_debug_wm);

	debugfs_create_file("fw_debug_wa", 0600, dir, dev, &fops_fw_debug_wa);

	debugfs_create_file("fw_util_wm", 0400, dir, dev,

			    &mt7915_fw_util_wm_fops);

	debugfs_create_file("fw_util_wa", 0400, dir, dev,

			    &mt7915_fw_util_wa_fops);

	debugfs_create_file("implicit_txbf", 0600, dir, dev,

			    &fops_implicit_txbf);

	debugfs_create_file("txpower_sku", 0400, dir, phy,

drivers/net/wireless/mediatek/mt76/mt7915/mcu.c

+2 −3
Original line number Diff line number Diff line
@@ -416,8 +416,7 @@ mt7915_mcu_send_message(struct mt76_dev *mdev, struct sk_buff *skb, 
	return mt76_tx_queue_skb_raw(dev, mdev->q_mcu[qid], skb, 0);

}



static int

mt7915_mcu_wa_cmd(struct mt7915_dev *dev, int cmd, u32 a1, u32 a2, u32 a3)

int mt7915_mcu_wa_cmd(struct mt7915_dev *dev, int cmd, u32 a1, u32 a2, u32 a3)

{

	struct {

		__le32 args[3];
@@ -429,7 +428,7 @@ mt7915_mcu_wa_cmd(struct mt7915_dev *dev, int cmd, u32 a1, u32 a2, u32 a3) 
		},

	};



	return mt76_mcu_send_msg(&dev->mt76, cmd, &req, sizeof(req), true);

	return mt76_mcu_send_msg(&dev->mt76, cmd, &req, sizeof(req), false);

}



static void

drivers/net/wireless/mediatek/mt76/mt7915/mcu.h

+2 −0
Original line number Diff line number Diff line
@@ -309,6 +309,8 @@ enum { 
};



enum {

	MCU_WA_PARAM_PDMA_RX = 0x04,

	MCU_WA_PARAM_CPU_UTIL = 0x0b,

	MCU_WA_PARAM_RED = 0x0e,

};

drivers/net/wireless/mediatek/mt76/mt7915/mmio.c

+3 −0
Original line number Diff line number Diff line
@@ -34,6 +34,9 @@ static u32 __mt7915_reg_addr(struct mt7915_dev *dev, u32 addr) 
		u32 mapped;

		u32 size;

	} fixed_map[] = {

		{ 0x00400000, 0x80000, 0x10000 }, /* WF_MCU_SYSRAM */

		{ 0x00410000, 0x90000, 0x10000 }, /* WF_MCU_SYSRAM (configure regs) */

		{ 0x40000000, 0x70000, 0x10000 }, /* WF_UMAC_SYSRAM */

		{ 0x54000000, 0x02000, 0x1000 }, /* WFDMA PCIE0 MCU DMA0 */

		{ 0x55000000, 0x03000, 0x1000 }, /* WFDMA PCIE0 MCU DMA1 */

		{ 0x58000000, 0x06000, 0x1000 }, /* WFDMA PCIE1 MCU DMA0 (MEM_DMA) */

drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h

+1 −0
Original line number Diff line number Diff line
@@ -450,6 +450,7 @@ int mt7915_mcu_get_rx_rate(struct mt7915_phy *phy, struct ieee80211_vif *vif, 
			   struct ieee80211_sta *sta, struct rate_info *rate);

int mt7915_mcu_rdd_cmd(struct mt7915_dev *dev, enum mt7915_rdd_cmd cmd,

		       u8 index, u8 rx_sel, u8 val);

int mt7915_mcu_wa_cmd(struct mt7915_dev *dev, int cmd, u32 a1, u32 a2, u32 a3);

int mt7915_mcu_fw_log_2_host(struct mt7915_dev *dev, u8 type, u8 ctrl);

int mt7915_mcu_fw_dbg_ctrl(struct mt7915_dev *dev, u32 module, u8 level);

void mt7915_mcu_rx_event(struct mt7915_dev *dev, struct sk_buff *skb);