Unverified Commit 90b14161 authored by Ravulapati Vishnu vardhan rao's avatar Ravulapati Vishnu vardhan rao Committed by Mark Brown
Browse files

ASoC: amd: Fix for Subsequent Playback issue. 



If we play audio back to back, which kills one playback
and immediately start another, we can hear clicks.
This patch fixes the issue.

Signed-off-by: default avatarRavulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
Link: https://lore.kernel.org/r/1580124397-19842-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0c75419a

sound/soc/amd/raven/acp3x-pcm-dma.c

+7 −7
Original line number Diff line number Diff line
@@ -349,13 +349,6 @@ static int acp3x_dma_close(struct snd_soc_component *component, 
	component = snd_soc_rtdcom_lookup(prtd, DRV_NAME);

	adata = dev_get_drvdata(component->dev);



	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {

		adata->play_stream = NULL;

		adata->i2ssp_play_stream = NULL;

	} else {

		adata->capture_stream = NULL;

		adata->i2ssp_capture_stream = NULL;

	}



	/* Disable ACP irq, when the current stream is being closed and

	 * another stream is also not active.
@@ -363,6 +356,13 @@ static int acp3x_dma_close(struct snd_soc_component *component, 
	if (!adata->play_stream && !adata->capture_stream &&

		!adata->i2ssp_play_stream && !adata->i2ssp_capture_stream)

		rv_writel(0, adata->acp3x_base + mmACP_EXTERNAL_INTR_ENB);

	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {

		adata->play_stream = NULL;

		adata->i2ssp_play_stream = NULL;

	} else {

		adata->capture_stream = NULL;

		adata->i2ssp_capture_stream = NULL;

	}

	return 0;

}