Commit 909ffe46 authored by Chris Mi's avatar Chris Mi Committed by Jakub Kicinski
Browse files

net/mlx5: E-switch, Don't update group if qos is not enabled 



Currently, qos group will be updated and qos will be enabled when
unregistering devlink port. Actually no need to update group if qos
is not enabled.

Add a check to prevent unnecessary enabling and disabling qos for
every port.

Signed-off-by: default avatarChris Mi <cmi@nvidia.com>
Reviewed-by: default avatarDmytro Linkin <dlinkin@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8c9cc1eb

drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c

+5 −1
Original line number Diff line number Diff line
@@ -924,12 +924,16 @@ int mlx5_esw_qos_vport_update_group(struct mlx5_eswitch *esw, 
				    struct mlx5_esw_rate_group *group,

				    struct netlink_ext_ack *extack)

{

	int err;

	int err = 0;



	mutex_lock(&esw->state_lock);

	if (!vport->qos.enabled && !group)

		goto unlock;



	err = esw_qos_vport_enable(esw, vport, 0, 0, extack);

	if (!err)

		err = esw_qos_vport_update_group(esw, vport, group, extack);

unlock:

	mutex_unlock(&esw->state_lock);

	return err;

}